[GH-ISSUE #860] Major updates #414

Closed
opened 2026-03-03 14:38:13 +03:00 by kerem · 6 comments
Owner

Originally created by @lipis on GitHub (Oct 22, 2021).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/860

Originally assigned to: @lipis on GitHub.

  • #859
  • Update SVGO to version 2
  • Add GitHub actions
  • Update front page with static web page
  • Switch to GitHub pages
  • Python script for keeping country.json in sync
Originally created by @lipis on GitHub (Oct 22, 2021). Original GitHub issue: https://github.com/lipis/flag-icons/issues/860 Originally assigned to: @lipis on GitHub. - [x] #859 - [x] Update SVGO to version 2 - [x] Add GitHub actions - [x] Update front page with static web page - [x] Switch to GitHub pages - [x] Python script for keeping `country.json` in sync
kerem closed this issue 2026-03-03 14:38:13 +03:00
Author
Owner

@NotTsunami commented on GitHub (Oct 23, 2021):

We were previously using svgo 2.3.1 prior to 3f7dfdbd89. Why did we drop to 1.x?

Also, I can submit a PR for GitHub Actions later.

<!-- gh-comment-id:950036281 --> @NotTsunami commented on GitHub (Oct 23, 2021): We were previously using svgo 2.3.1 prior to 3f7dfdbd89ca2fe3ecede6faff5a5595a04f8d62. Why did we drop to 1.x? Also, I can submit a PR for GitHub Actions later.
Author
Owner

@lipis commented on GitHub (Oct 23, 2021):

@NotTsunami I couldn't make it work with svgo.yaml config and use the commands from package.json.

If you can make it work.. please submit a PR for it with the latest svgo..

<!-- gh-comment-id:950110041 --> @lipis commented on GitHub (Oct 23, 2021): @NotTsunami I couldn't make it work with `svgo.yaml` config and use the commands from `package.json`. If you can make it work.. please submit a PR for it with the latest svgo..
Author
Owner

@lipis commented on GitHub (Oct 23, 2021):

Also, I can submit a PR for GitHub Actions later.

Please do.

<!-- gh-comment-id:950110157 --> @lipis commented on GitHub (Oct 23, 2021): > Also, I can submit a PR for GitHub Actions later. Please do.
Author
Owner

@lipis commented on GitHub (Oct 23, 2021):

@NotTsunami https://github.com/svg/svgo/releases/tag/v2.0.0

Inlined json config is no longer supported. CLI flags should be used instead.

<!-- gh-comment-id:950110365 --> @lipis commented on GitHub (Oct 23, 2021): @NotTsunami https://github.com/svg/svgo/releases/tag/v2.0.0 > Inlined json config is no longer supported. CLI flags should be used instead.
Author
Owner

@NotTsunami commented on GitHub (Oct 25, 2021):

For svgo see #869. The new svgo.config.js is identical to our current config, and svgo automatically searches for it so it doesn't need to be specified in the command line.

<!-- gh-comment-id:950586649 --> @NotTsunami commented on GitHub (Oct 25, 2021): For svgo see #869. The new `svgo.config.js` is identical to our current config, and svgo automatically searches for it so it doesn't need to be specified in the command line.
Author
Owner

@lipis commented on GitHub (Oct 25, 2021):

Thank youuu!

<!-- gh-comment-id:950695921 --> @lipis commented on GitHub (Oct 25, 2021): Thank youuu!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flag-icons#414
No description provided.