[GH-ISSUE #766] Some country/region flags are broken/glitched #388

Closed
opened 2026-03-03 14:38:02 +03:00 by kerem · 3 comments
Owner

Originally created by @NotTsunami on GitHub (Oct 14, 2020).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/766

Hi, I am a frequent contributor to qBittorrent and recently they stumbled across an issue where some of the flags were malformed or displayed incorrectly in qBittorrent. I do not believe this is due to a Qt bug because they ran svgcleaner on all of the flags and this seemed to resolve the issue. This issue is extended from https://github.com/qbittorrent/qBittorrent/issues/13497. The issue arose from https://github.com/qbittorrent/qBittorrent/pull/12941. The breaking commit from here is likely b0c4c3c83c or a235746af0.

The flags reported were (potentially not limited to):

  • Brazil
  • Hong Kong
  • Portugal
  • Spain
  • Taiwan

I think this needs some more research, but I am trying to figure out if any paths were erroneously optimized or overoptimized. Regardless, all flags display fine through web renders, so something that was optimized apparently does not play nice with Qt, and svgcleaner seems to fix it.

Originally created by @NotTsunami on GitHub (Oct 14, 2020). Original GitHub issue: https://github.com/lipis/flag-icons/issues/766 Hi, I am a frequent contributor to qBittorrent and recently they stumbled across an issue where some of the flags were malformed or displayed incorrectly in qBittorrent. I do not believe this is due to a Qt bug because they ran svgcleaner on all of the flags and this seemed to resolve the issue. This issue is extended from https://github.com/qbittorrent/qBittorrent/issues/13497. The issue arose from https://github.com/qbittorrent/qBittorrent/pull/12941. The breaking commit from here is likely b0c4c3c83c8055d1da50c4fdd2a7f03655a4926a or a235746af0fcde361adef551bfdc311218ea75bd. The flags reported were (potentially not limited to): - Brazil - Hong Kong - Portugal - Spain - Taiwan I think this needs some more research, but I am trying to figure out if any paths were erroneously optimized or overoptimized. Regardless, all flags display fine through web renders, so something that was optimized apparently does not play nice with Qt, and svgcleaner seems to fix it.
kerem closed this issue 2026-03-03 14:38:03 +03:00
Author
Owner

@lipis commented on GitHub (Nov 6, 2020):

I'm aware that some flags are not perfect... let's keep one issue per flag or something.. I'll close this one.

<!-- gh-comment-id:722714561 --> @lipis commented on GitHub (Nov 6, 2020): I'm aware that some flags are not perfect... let's keep one issue per flag or something.. I'll close this one.
Author
Owner

@NotTsunami commented on GitHub (Nov 6, 2020):

It's not so much a design issue, I'm curious as to whether or not it's a bug with Qt's SVG library or an overoptimization on some flags.

It's something that needs more research for certain, and I doubt it can be limited to a single flag.

<!-- gh-comment-id:722754101 --> @NotTsunami commented on GitHub (Nov 6, 2020): It's not so much a design issue, I'm curious as to whether or not it's a bug with Qt's SVG library or an overoptimization on some flags. It's something that needs more research for certain, and I doubt it can be limited to a single flag.
Author
Owner

@lipis commented on GitHub (Nov 8, 2020):

They work fine in the browsers.. but in general one flag per issue it's easier to keep track.

<!-- gh-comment-id:723626270 --> @lipis commented on GitHub (Nov 8, 2020): They work fine in the browsers.. but in general one flag per issue it's easier to keep track.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flag-icons#388
No description provided.