mirror of
https://github.com/lipis/flag-icons.git
synced 2026-04-26 09:25:50 +03:00
[GH-ISSUE #600] Catalan flag does not follow ISO-639 language code #339
Labels
No labels
3rd-party
3rd-party
bug
code
documentation
enhancement
fixed-in-master
flag-request
help needed
missing-flag
missing-flag
pull-request
wrong-flag
wrong-flag
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flag-icons#339
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AzaZPPL on GitHub (Sep 17, 2019).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/600
The Catalan flag has been added in https://github.com/lipis/flag-icon-css/pull/374 with the extension of 'ct'. The ISO-639-1 Language code for Catalan is 'ca'.
The class name should be changed 'flag-icon-es-ct' to 'flag-icon-es-ca'. We could also keep it backward compatible by only adding the 'flag-icon-es-ca'.
@lipis commented on GitHub (Sep 30, 2019):
source?
@AzaZPPL commented on GitHub (Sep 30, 2019):
https://www.loc.gov/standards/iso639-2/php/code_list.php
@lipis commented on GitHub (Oct 1, 2019):
these are the language codes.. we store country codes
@lipis commented on GitHub (Oct 1, 2019):
and ca is already taken by Canada
@AzaZPPL commented on GitHub (Oct 1, 2019):
Catalan is not a country. It's a specific region inside of Spain. If you only want to store country codes it makes no sense to add Catalan to this list anyway.
The current usage is with
es-ct. If we change it toes-cait will not replace Canada which isca.Since this package is also following ISO 3166-1-alpha-2 code of a country with some region support, it only makes sense that it also uses the ISO 639-1 to give a proper key to those region flags and not some randomly thought up one.
@lipis commented on GitHub (Oct 1, 2019):
you might have some points here..
@lipis commented on GitHub (Oct 1, 2019):
Do you mind opening a PR? no need for backwards compatibility..
@AzaZPPL commented on GitHub (Oct 4, 2019):
Sure I'll write one right now
@markusand commented on GitHub (Aug 4, 2020):
I consider this not being an appropriate change. As pointed previously ISO 639-1 codes are used for languages (and using flags to identify a language is always a bad idea) while the ISO 3166-2 are the codes used to identify country subdivisions. In the case of Catalunya the ISO 3166-2:ES code happens to be es-ct.