mirror of
https://github.com/lipis/flag-icons.git
synced 2026-04-26 01:15:55 +03:00
[GH-ISSUE #537] Add flags for AC and TA #317
Labels
No labels
3rd-party
3rd-party
bug
code
documentation
enhancement
fixed-in-master
flag-request
help needed
missing-flag
missing-flag
pull-request
wrong-flag
wrong-flag
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flag-icons#317
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @catamphetamine on GitHub (Mar 10, 2019).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/537
The flags for
ACandTAare currently missing from this library.Quote from WikiPedia:
https://en.wikipedia.org/wiki/ISO_3166-2:SH
AC— Ascension Island.https://en.wikipedia.org/wiki/Ascension_Island
Flag in SVG format (
78kBafter SVGO: too much detail, too large in size, would have to be reduced to simple shapes): https://upload.wikimedia.org/wikipedia/commons/6/65/Flag_of_Ascension_Island.svgTA— Tristan da Cunha.https://en.wikipedia.org/wiki/Tristan_da_Cunha
Flag in SVG format (
14kBafter SVGO): https://upload.wikimedia.org/wikipedia/commons/8/89/Flag_of_Tristan_da_Cunha.svg@catamphetamine commented on GitHub (Mar 15, 2019):
@lipis Do you want a pull request?
@bessone commented on GitHub (Oct 31, 2019):
Hey @lipis, Is there a reason why you did not accept the PR?
@lipis commented on GitHub (Oct 31, 2019):
Because they are not countries.. yes we have a few, but that's because they represented in Football for example.. and we needed them in projects.
@catamphetamine commented on GitHub (Oct 31, 2019):
@lipis You also have Kosovo (XK) flag and Kosovo is also not a country.
Your inclusion/exclusion criteria are inconsistent.
@bessone commented on GitHub (Oct 31, 2019):
I think respect all the ISO 3166-1 alpha-2 (https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2) with the extension could be a good idea, in this way if a code that respect ISO return a country code we have a flag for it!
@catamphetamine commented on GitHub (Oct 31, 2019):
@bessone Well, there's no real reason not to include any valid ISO code flags in this repo, even when they're for country subdivisions, not countries themselves (like in this case).
Even Kosovo (XK) got included and XK code is not even officially assigned to anything in the ISO standard, while AC and TA, for example, are officially assigned by the ISO organization.
@paulmorar commented on GitHub (Jun 15, 2020):
I am also of the same opinion as @bessone and @catamphetamine.
There is no good reason to not add this to the library. You need to think about it being able to work together with other libraries.
The way I see it, merging this PR:
Downsides:
But thinking about open source, the pros far outweigh the cons.
@NotTsunami commented on GitHub (Oct 14, 2020):
I just saw this issue, I opened a new PR that includes these and a few more flags. Even if they are not defined by ISO 3166-1 explicitly, they are included in the Unicode/Emoji 1.0 spec and I believe that is enough to warrant the addition of these. My PR uses existing flags for flags that are inherited. I have also added them to the "more flags" category so they are not included with the base, which I think is a reasonable compromise.