[GH-ISSUE #379] Classes for white background #233

Closed
opened 2026-03-03 14:35:41 +03:00 by kerem · 3 comments
Owner

Originally created by @rgvy on GitHub (Jul 29, 2017).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/379

Hello

If a flag with a white background is placed on a white background, it can be hard to identify the flag. (Example Japan). It is for this reason, I suggest the following enhancement: .flag-icon-bordered add something like border: 1px solid #ddd.

Thx!

Originally created by @rgvy on GitHub (Jul 29, 2017). Original GitHub issue: https://github.com/lipis/flag-icons/issues/379 Hello If a flag with a white background is placed on a white background, it can be hard to identify the flag. (Example Japan). It is for this reason, I suggest the following enhancement: `.flag-icon-bordered` add something like `border: 1px solid #ddd`. Thx!
kerem closed this issue 2026-03-03 14:35:41 +03:00
Author
Owner

@tmgldn commented on GitHub (Nov 27, 2017):

Did the research and it seems there are very few flags with grey on the outside:

Valle del Cauca Department (not a country) #e7e7e7
Santiago Metropolitan Region (not a country) #585767

So #ddd seems very safe

<!-- gh-comment-id:347064849 --> @tmgldn commented on GitHub (Nov 27, 2017): Did the research and it seems there are very few flags with grey on the outside: Valle del Cauca Department (not a country) #e7e7e7 Santiago Metropolitan Region (not a country) #585767 So #ddd seems very safe
Author
Owner

@tmgldn commented on GitHub (Nov 27, 2017):

@lipis I've fixed this locally, is there any chance you could add me as a contributor so I can create a pull request for this issue

<!-- gh-comment-id:347067878 --> @tmgldn commented on GitHub (Nov 27, 2017): @lipis I've fixed this locally, is there any chance you could add me as a contributor so I can create a pull request for this issue
Author
Owner

@lipis commented on GitHub (Nov 27, 2017):

anyone can create a PR.. you don't have to be part of the team for that..

<!-- gh-comment-id:347068087 --> @lipis commented on GitHub (Nov 27, 2017): anyone can create a PR.. you don't have to be part of the team for that..
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flag-icons#233
No description provided.