mirror of
https://github.com/lipis/flag-icons.git
synced 2026-04-26 09:25:50 +03:00
[GH-ISSUE #379] Classes for white background #233
Labels
No labels
3rd-party
3rd-party
bug
code
documentation
enhancement
fixed-in-master
flag-request
help needed
missing-flag
missing-flag
pull-request
wrong-flag
wrong-flag
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flag-icons#233
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rgvy on GitHub (Jul 29, 2017).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/379
Hello
If a flag with a white background is placed on a white background, it can be hard to identify the flag. (Example Japan). It is for this reason, I suggest the following enhancement:
.flag-icon-borderedadd something likeborder: 1px solid #ddd.Thx!
@tmgldn commented on GitHub (Nov 27, 2017):
Did the research and it seems there are very few flags with grey on the outside:
Valle del Cauca Department (not a country) #e7e7e7
Santiago Metropolitan Region (not a country) #585767
So #ddd seems very safe
@tmgldn commented on GitHub (Nov 27, 2017):
@lipis I've fixed this locally, is there any chance you could add me as a contributor so I can create a pull request for this issue
@lipis commented on GitHub (Nov 27, 2017):
anyone can create a PR.. you don't have to be part of the team for that..