mirror of
https://github.com/lipis/flag-icons.git
synced 2026-04-26 09:25:50 +03:00
[GH-ISSUE #370] Create a "Won't-include-list" #230
Labels
No labels
3rd-party
3rd-party
bug
code
documentation
enhancement
fixed-in-master
flag-request
help needed
missing-flag
missing-flag
pull-request
wrong-flag
wrong-flag
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flag-icons#230
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tomlutzenberger on GitHub (May 22, 2017).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/370
It would be helpful for contributors to create a document or section in the README with all the flags you don't want to include. I think of a list with the name/country of a flag and the reason for exclusion.
Pros:
Cons:
If you need a helping hand, let me know 😃
@sustained commented on GitHub (Jul 2, 2017):
Why would you not want to include some flags? Seems ridiculous.
Should rename this project to "only-some-flags-icon-css" in that case.
@tomlutzenberger commented on GitHub (Jul 2, 2017):
Because it's necessary. @lipis mentioned about a thousand times, that he will only include official flags of countries which are in ISO 3166-1-alpha-2.
Otherwise people will come up with some flag only he/she might need once in a lifetime and the project will end with a million flags including every karate club flag in south-east-asia and every.
That would be ridiculous.
@sustained commented on GitHub (Jul 2, 2017):
Oh, right, of course, I thought that would be obvious to people.
I was under the impression that only a subset of ISO flags were being included, or something. 👅
@lipis commented on GitHub (Oct 19, 2018):
As there is no a general rule I will close this issue... In the beginning I was only including the ISO 3166, but there were strong arguments (World Cup, Euro Cup, etc) for including some more flags..