[GH-ISSUE #335] Remove underscore from root scss file #208

New issue

Closed

opened 2026-03-03 14:35:28 +03:00 by kerem · 4 comments

kerem commented

2026-03-03 14:35:28 +03:00

Owner

Originally created by @dmersiowsky on GitHub (Jan 5, 2017).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/335

When trying to import flag-icon-css through sass @import statement, linting fails with:
"Unexpected leading underscore in imported partial name"

The import statement is
@import "flag-icon-css/sass/_flag-icon";

As _flag-icon.scss seems to be the root SASS file, it should not have an underscore.
(This also makes it easier for other people to find out which file to include.)

Originally created by @dmersiowsky on GitHub (Jan 5, 2017). Original GitHub issue: https://github.com/lipis/flag-icons/issues/335 When trying to import flag-icon-css through sass `@import` statement, linting fails with: "Unexpected leading underscore in imported partial name" The import statement is `@import "flag-icon-css/sass/_flag-icon";` As `_flag-icon.scss` seems to be the root SASS file, it should not have an underscore. (This also makes it easier for other people to find out which file to include.)

kerem closed this issue

2026-03-03 14:35:28 +03:00

kerem commented

2026-03-03 14:35:29 +03:00

Author

Owner

@lipis commented on GitHub (Jan 5, 2017):

Do you mind providing a PR.. or I can do it later this week

@lipis commented on GitHub (Jan 5, 2017): Do you mind providing a PR.. or I can do it later this week

kerem commented

2026-03-03 14:35:29 +03:00

Author

Owner

@dmersiowsky commented on GitHub (Jan 5, 2017):

Here you go :)

@dmersiowsky commented on GitHub (Jan 5, 2017): Here you go :)

kerem commented

2026-03-03 14:35:29 +03:00

Author

Owner

@lipis commented on GitHub (Jan 6, 2017):

Thank you!! Sorry for taking a bit longer..

@lipis commented on GitHub (Jan 6, 2017): Thank you!! Sorry for taking a bit longer..

kerem commented

2026-03-03 14:35:29 +03:00

Author

Owner

@dmersiowsky commented on GitHub (Jan 7, 2017):

Thanks for merging! No worries, I have seen pull requests taking waaay longer ;-)

@dmersiowsky commented on GitHub (Jan 7, 2017): Thanks for merging! No worries, I have seen pull requests taking waaay longer ;-)

kerem referenced this issue

2026-03-03 14:40:21 +03:00

[PR #208] [CLOSED] Printing the flag! #699