mirror of
https://github.com/lipis/flag-icons.git
synced 2026-04-26 09:25:50 +03:00
[GH-ISSUE #224] Wrong flag for United Kingdom (GB) #147
Labels
No labels
3rd-party
3rd-party
bug
code
documentation
enhancement
fixed-in-master
flag-request
help needed
missing-flag
missing-flag
pull-request
wrong-flag
wrong-flag
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flag-icons#147
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lipis on GitHub (Apr 13, 2016).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/224
Originally assigned to: @AndyLnd on GitHub.
https://en.wikipedia.org/wiki/Flag_of_the_United_Kingdom#/media/File:Flag_of_the_United_Kingdom.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/gb.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/1x1/gb.svg
@Naituw commented on GitHub (May 18, 2016):
Can't see any difference 😂
@lipis commented on GitHub (May 18, 2016):
Look closer.. :)
@WillXing commented on GitHub (May 19, 2016):
is the height of the horizontal red belt....?
@jbialobr commented on GitHub (Jun 17, 2016):
The wiki flag has 8 dark blue triangles. The 4x3 gb.svg has 4 triangles and 4 trapezes.
@ais-one commented on GitHub (Apr 9, 2018):
looks like flag width has been shortened
@mrchief commented on GitHub (Apr 10, 2018):
More like resized (width only) and then cropped...
@lipis commented on GitHub (Apr 11, 2018):
One of the most difficult ones to solve :)
@mrchief commented on GitHub (Apr 11, 2018):
This project is great but the number of open issues and the velocity makes me reluctant to use it. For my current needs, I can live without SVG (and even just having 16x16 png); but it'd be great to see the issues (at least the wrong and missing flag ones resolved ASAP).
I can pitch in a bit, my illustrator/svg skills are beginner level at best but I think that might suffice.
(I tried doing that with Font Awesome and later found out that icon contributions were off limits, so if something like that is not an factor here, I can help).
@mrchief commented on GitHub (Apr 11, 2018):
I fiddled a bit and I see your point now... 😞
@mrchief commented on GitHub (Apr 11, 2018):
Although, one could argue that this is inevitable (making square flags out of rectanglular ones) .
It's the same problem video editors have, trying to fit widescreen formats scale to 4:3 or other formats - they solve it using blackboxes or crops. Crops lead to data loss but is the better option here (rather than having blackboxes in this case).
So, not an issue then? 😄
@lipis commented on GitHub (Apr 11, 2018):
I just didn't manage to do it using Inkscape.
@mareg commented on GitHub (Feb 2, 2019):
Every flag has its aspect ratio defined - I would like to see all flags by default in their original aspect ratios. E.g. Switzerland's flag is 1x1, so displaying it in 4x3 is incorrect (and some may find it disrespectful).
@Findus23 commented on GitHub (Feb 3, 2019):
@mareg The issue is that nearly every single flag has a different aspect ratio which makes it hard to use them as an icon:
https://en.wikipedia.org/wiki/List_of_aspect_ratios_of_national_flags
If you need the "original" flags, you don't need this project, but could instead directly use the SVGs from above Wikipedia entry.
@mareg commented on GitHub (Feb 6, 2019):
@Findus23 but that would mean a manual work for every project - if this project is list of flags, I'd prefer all flags in their original aspect ratio - then using css it's easy to place them inside square/circle/rectangle and fit/zoom/stretch/what not - for a particular use. Or if user users mostly are looking for 1x1 and/or 4x3 ratio, then have three sizes: original, 1x1, 4x3.
@seanfoo commented on GitHub (Feb 6, 2019):
I may be wrong, but I believe that if you wanted to contribute a set of
original aspected flags you could upload them as a pull in github. My
terminology may be off.
sean
Sean Forman
Sports Reference LLC, President, http://www.sports-reference.com/
https://twitter.com/sean_forman https://www.linkedin.com/in/seanforman
On Wed, Feb 6, 2019 at 5:31 AM Marek Matulka notifications@github.com
wrote:
@lipis commented on GitHub (Feb 6, 2019):
@mareg I would also prefer to have a world peace, but that's not the case :)
This project has 2 aspect ratios for all flags.. if you don't like it.. don't use it :)
@mrchief commented on GitHub (Feb 6, 2019):
@mareg like @lipis said, this is probably not the right project for you. I found this: https://github.com/hjnilsson/country-flags which seems to have the flags in their native aspect ratio which might be a better fit for you.
@itsAnuga commented on GitHub (Apr 25, 2019):
A side note for UK, it's a country of countries, and those flags are missing as well :)
Countries of United Kingdom
My bad, their not visible on the display page, but exists in the image folders.
@AndyLnd commented on GitHub (Oct 1, 2019):
The fix for the 1x1 version is here: https://github.com/lipis/flag-icon-css/pull/615
🇬🇧