[GH-ISSUE #29] Sri Lankan flag issue #14

Closed
opened 2026-03-03 14:33:56 +03:00 by kerem · 5 comments
Owner
Originally created by @chris-gunawardena on GitHub (Sep 4, 2014). Original GitHub issue: https://github.com/lipis/flag-icons/issues/29 Current: http://lipis.github.io/flag-icon-css/flags/4x3/lk.svg ![Current Sri Lankan flag](http://lipis.github.io/flag-icon-css/flags/4x3/lk.svg) Expected: http://upload.wikimedia.org/wikipedia/commons/1/11/Flag_of_Sri_Lanka.svg ![Current Sri Lankan flag](http://upload.wikimedia.org/wikipedia/commons/1/11/Flag_of_Sri_Lanka.svg)
kerem closed this issue 2026-03-03 14:33:56 +03:00
Author
Owner

@lipis commented on GitHub (Oct 18, 2014):

I think the problem was from the original project that all the flags were 4x3 or 1x1 ratio.. as this flag is not in 4x3 the original creator modified it a bit to make it fit.. yes it's wrong to modify the flags, but in the web sometimes we just want a small flag/icon to represent it.. as I can see in this one the colors are also different which should definitely updated.

Another idea to fix it maybe it would be to stretch the background to fit the 4x3.. WDYT?

<!-- gh-comment-id:59605878 --> @lipis commented on GitHub (Oct 18, 2014): I think the problem was from the original project that all the flags were 4x3 or 1x1 ratio.. as this flag is not in 4x3 the original creator modified it a bit to make it fit.. yes it's wrong to modify the flags, but in the web sometimes we just want a small flag/icon to represent it.. as I can see in this one the colors are also different which should definitely updated. Another idea to fix it maybe it would be to stretch the background to fit the 4x3.. WDYT?
Author
Owner

@yaniv691 commented on GitHub (May 10, 2015):

I think stretching the background height so the original design fits a 4x3 ratio is a good idea. The flag's original design should be first priority, with some stretching if needed. Can you please update the Sri Lankan flag?

<!-- gh-comment-id:100713620 --> @yaniv691 commented on GitHub (May 10, 2015): I think stretching the background height so the original design fits a 4x3 ratio is a good idea. The flag's original design should be first priority, with some stretching if needed. Can you please update the Sri Lankan flag?
Author
Owner

@lipis commented on GitHub (May 11, 2015):

Fixed in #69.. can you please check if it's ok?

<!-- gh-comment-id:100722226 --> @lipis commented on GitHub (May 11, 2015): Fixed in #69.. can you please check if it's ok?
Author
Owner

@yaniv691 commented on GitHub (May 11, 2015):

@chris-gunawardena, correct me if I'm wrong, but I think stretching the yellow background is better than stretching the elements on the flag.

<!-- gh-comment-id:100762472 --> @yaniv691 commented on GitHub (May 11, 2015): @chris-gunawardena, correct me if I'm wrong, but I think stretching the yellow background is better than stretching the elements on the flag.
Author
Owner

@chris-gunawardena commented on GitHub (May 12, 2015):

Looks good to me. The colours represents different ethnicities and this is closest to the original colour ratios.
screen shot 2015-05-12 at 10 03 16 pm

Thanks for all the input and great work put into fixing this guys!

<!-- gh-comment-id:101253645 --> @chris-gunawardena commented on GitHub (May 12, 2015): Looks good to me. The colours represents different ethnicities and this is closest to the original colour ratios. ![screen shot 2015-05-12 at 10 03 16 pm](https://cloud.githubusercontent.com/assets/5763108/7586697/c711713e-f8f2-11e4-95d8-371a364827d5.png) Thanks for all the input and great work put into fixing this guys!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flag-icons#14
No description provided.