mirror of
https://github.com/lipis/flag-icons.git
synced 2026-04-27 01:46:02 +03:00
[GH-ISSUE #29] Sri Lankan flag issue #14
Labels
No labels
3rd-party
3rd-party
bug
code
documentation
enhancement
fixed-in-master
flag-request
help needed
missing-flag
missing-flag
pull-request
wrong-flag
wrong-flag
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flag-icons#14
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @chris-gunawardena on GitHub (Sep 4, 2014).
Original GitHub issue: https://github.com/lipis/flag-icons/issues/29
Current:

http://lipis.github.io/flag-icon-css/flags/4x3/lk.svg
Expected:

http://upload.wikimedia.org/wikipedia/commons/1/11/Flag_of_Sri_Lanka.svg
@lipis commented on GitHub (Oct 18, 2014):
I think the problem was from the original project that all the flags were 4x3 or 1x1 ratio.. as this flag is not in 4x3 the original creator modified it a bit to make it fit.. yes it's wrong to modify the flags, but in the web sometimes we just want a small flag/icon to represent it.. as I can see in this one the colors are also different which should definitely updated.
Another idea to fix it maybe it would be to stretch the background to fit the 4x3.. WDYT?
@yaniv691 commented on GitHub (May 10, 2015):
I think stretching the background height so the original design fits a 4x3 ratio is a good idea. The flag's original design should be first priority, with some stretching if needed. Can you please update the Sri Lankan flag?
@lipis commented on GitHub (May 11, 2015):
Fixed in #69.. can you please check if it's ok?
@yaniv691 commented on GitHub (May 11, 2015):
@chris-gunawardena, correct me if I'm wrong, but I think stretching the yellow background is better than stretching the elements on the flag.
@chris-gunawardena commented on GitHub (May 12, 2015):
Looks good to me. The colours represents different ethnicities and this is closest to the original colour ratios.

Thanks for all the input and great work put into fixing this guys!