[PR #1373] [CLOSED] Incorrect ISO:false designations #1378

New issue

Closed

opened 2026-03-03 14:43:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 14:43:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lipis/flag-icons/pull/1373
Author: @p2made
Created: 6/5/2025
Status: ❌ Closed

Base: main ← Head: p2made

📝 Commits (6)

5afebdc Update .gitignore
ddeda35 Update .gitignore
c172fb9 Update .gitignore
2485646 Merge pull request #1 from p2made/gitignore
b88dc25 build
6752c62 Build

📊 Changes

5 files changed (+1609 additions, -1590 deletions)

View changed files

📝 .gitignore (+1 -1)
📝 country.json (+1487 -1474)
📝 css/flag-icons.css (+99 -98)
📝 css/flag-icons.min.css (+1 -1)
📝 sass/_variables.scss (+21 -16)

📄 Description

There are a few flags which are listed as not being ISO when they actually are. Those flags are...

Code	Name	Wikipedia
es-ct	Catalonia	https://en.wikipedia.org/wiki/Catalonia
es-ga	Galicia	https://en.wikipedia.org/wiki/Galicia_(Spain)
es-pv	Basque Country	https://en.wikipedia.org/wiki/Basque_Country_(autonomous_community)
gb-eng	England	https://en.wikipedia.org/wiki/England
gb-sct	Scotland	https://en.wikipedia.org/wiki/Scotland
gb-wls	Wales	https://en.wikipedia.org/wiki/Wales
sh-ac	Ascension Island	https://en.wikipedia.org/wiki/Ascension_Island
sh-hl	Saint Helena	https://en.wikipedia.org/wiki/Saint_Helena
sh-ta	Tristan da Cunha	https://en.wikipedia.org/wiki/Tristan_da_Cunha

All of them are first level sub-divisions of the countries they belong to. Most, if not all (& all in my experience), such first level sub-divisions have ISO designations taking the form, country ISO code, a hyphen, 2 or 3 alphanumeric characters.

In the interest of quality curation, I believe that these flags, & any future ones like them, should be listed as being ISO.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lipis/flag-icons/pull/1373 **Author:** [@p2made](https://github.com/p2made) **Created:** 6/5/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `p2made` --- ### 📝 Commits (6) - [`5afebdc`](https://github.com/lipis/flag-icons/commit/5afebdcf915f46ad4bab628d7c256d7bbfc8bdbe) Update .gitignore - [`ddeda35`](https://github.com/lipis/flag-icons/commit/ddeda350c5ec2ec53387eef07dfb782c73c7c83f) Update .gitignore - [`c172fb9`](https://github.com/lipis/flag-icons/commit/c172fb9c1d2a825e2c3a4438f01641bcb0ba0fc2) Update .gitignore - [`2485646`](https://github.com/lipis/flag-icons/commit/2485646ccf2a1de7698cd53abc04f4df65022e9f) Merge pull request #1 from p2made/gitignore - [`b88dc25`](https://github.com/lipis/flag-icons/commit/b88dc25d7b877ce0edbab117ad40ee0e1b2500c9) build - [`6752c62`](https://github.com/lipis/flag-icons/commit/6752c62d3eb7f414347211ef49db1b958bbf06d5) Build ### 📊 Changes **5 files changed** (+1609 additions, -1590 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) 📝 `country.json` (+1487 -1474) 📝 `css/flag-icons.css` (+99 -98) 📝 `css/flag-icons.min.css` (+1 -1) 📝 `sass/_variables.scss` (+21 -16) </details> ### 📄 Description There are a few flags which are listed as not being ISO when they actually are. Those flags are... Code | Name | Wikipedia ------ | ---------------- | --------- es-ct | Catalonia | https://en.wikipedia.org/wiki/Catalonia es-ga | Galicia | https://en.wikipedia.org/wiki/Galicia_(Spain) es-pv | Basque Country | https://en.wikipedia.org/wiki/Basque_Country_(autonomous_community) gb-eng | England | https://en.wikipedia.org/wiki/England gb-sct | Scotland | https://en.wikipedia.org/wiki/Scotland gb-wls | Wales | https://en.wikipedia.org/wiki/Wales sh-ac | Ascension Island | https://en.wikipedia.org/wiki/Ascension_Island sh-hl | Saint Helena | https://en.wikipedia.org/wiki/Saint_Helena sh-ta | Tristan da Cunha | https://en.wikipedia.org/wiki/Tristan_da_Cunha All of them are first level sub-divisions of the countries they belong to. Most, if not all (& all in my experience), such first level sub-divisions have ISO designations taking the form, country ISO code, a hyphen, 2 or 3 alphanumeric characters. In the interest of quality curation, I believe that these flags, & any future ones like them, should be listed as being ISO. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>