[PR #1288] [MERGED] Remove <text> elements from Guam flag #1313

Closed
opened 2026-03-03 14:43:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/lipis/flag-icons/pull/1288
Author: @tfoxkiu
Created: 9/19/2024
Status: Merged
Merged: 10/3/2024
Merged by: @NotTsunami

Base: mainHead: gu-fix


📝 Commits (1)

  • 141476a Remove <text> elements from Guam flag

📊 Changes

2 files changed (+0 additions, -8 deletions)

View changed files

📝 flags/1x1/gu.svg (+0 -4)
📝 flags/4x3/gu.svg (+0 -4)

📄 Description

I created an issue in https://github.com/iconify/icon-sets because the gu icon is missing: https://github.com/iconify/icon-sets/issues/132

From there I realized that https://github.com/lipis/flag-icons/pull/967 was supposed to fix this, but gu still has <text> elements (while in sm they were removed). I can remove them and the letters still show (the text elements are rendered as a white "shadow"), so I'm not sure if this was an oversight.

With text elements:
image

Without text elements:
image

Let me know if there's anything else needed for this PR.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/lipis/flag-icons/pull/1288 **Author:** [@tfoxkiu](https://github.com/tfoxkiu) **Created:** 9/19/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@NotTsunami](https://github.com/NotTsunami) **Base:** `main` ← **Head:** `gu-fix` --- ### 📝 Commits (1) - [`141476a`](https://github.com/lipis/flag-icons/commit/141476a4ce03db471c37ec01d6576df68c5bc5eb) Remove `<text>` elements from Guam flag ### 📊 Changes **2 files changed** (+0 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `flags/1x1/gu.svg` (+0 -4) 📝 `flags/4x3/gu.svg` (+0 -4) </details> ### 📄 Description I created an issue in https://github.com/iconify/icon-sets because the `gu` icon is missing: https://github.com/iconify/icon-sets/issues/132 From there I realized that https://github.com/lipis/flag-icons/pull/967 was supposed to fix this, but `gu` still has `<text>` elements (while in `sm` they were removed). I can remove them and the letters still show (the text elements are rendered as a white "shadow"), so I'm not sure if this was an oversight. With text elements:\ ![image](https://github.com/user-attachments/assets/97b6d105-e17c-41eb-a0e4-f691d0147ab0) Without text elements:\ ![image](https://github.com/user-attachments/assets/6a161400-645d-40ca-ac8f-864601f4b594) Let me know if there's anything else needed for this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 14:43:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flag-icons#1313
No description provided.