[PR #167] [MERGED] System{Info,Logs}: use sh instead of bash #187

Closed
opened 2026-03-03 11:59:18 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/finmars-platform/finmars-core/pull/167
Author: @HenkKalkwater
Created: 2/2/2026
Status: Merged
Merged: 2/6/2026
Merged by: @paktusov

Base: mainHead: 62-fix-system-info-logs-500-error


📝 Commits (1)

  • 205fdbc System{Info,Logs}: use sh instead of bash

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 poms/api/views.py (+4 -4)

📄 Description

Bash is not available in Alpine images. In
bb1ce0a038, the Docker image was changed to Alpine from Debian, which caused 500 errors in the SystemInfoViewSet and SystemLogsViewSet.

Now it calls "sh" instead of "/bin/bash", which should be more portable across different distributions. Since no bash-exclusive features were used, this was trivial.

Fixes finmars-platform/finmars-core#62


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/finmars-platform/finmars-core/pull/167 **Author:** [@HenkKalkwater](https://github.com/HenkKalkwater) **Created:** 2/2/2026 **Status:** ✅ Merged **Merged:** 2/6/2026 **Merged by:** [@paktusov](https://github.com/paktusov) **Base:** `main` ← **Head:** `62-fix-system-info-logs-500-error` --- ### 📝 Commits (1) - [`205fdbc`](https://github.com/finmars-platform/finmars-core/commit/205fdbc05a8f35a2f2a073985e4714bf10f7feb5) System{Info,Logs}: use sh instead of bash ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `poms/api/views.py` (+4 -4) </details> ### 📄 Description Bash is not available in Alpine images. In bb1ce0a0388a5b0ee90b4ceb669ec39dc567f395, the Docker image was changed to Alpine from Debian, which caused 500 errors in the SystemInfoViewSet and SystemLogsViewSet. Now it calls "sh" instead of "/bin/bash", which should be more portable across different distributions. Since no bash-exclusive features were used, this was trivial. Fixes finmars-platform/finmars-core#62 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem closed this issue 2026-03-03 11:59:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/finmars-core#187
No description provided.