[PR #176] [MERGED] utils/attr_is_relation: add portfolio_type to relation set #186

New issue

Closed

opened 2026-03-03 11:59:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 11:59:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/finmars-platform/finmars-core/pull/176
Author: @HenkKalkwater
Created: 2/13/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @paktusov

Base: main ← Head: add-portfolio-type-attr-to-relation-set

📝 Commits (1)

6ceaa54 utils/attr_is_relation: add portfolio_type to relation set

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 poms/common/utils.py (+1 -0)

📄 Description

/api/v1/portfolios/portfolio/ev-group/ returned group_name and group_identifier as numbers instead of strings. Other endpoints, like /api/v1/instruments/instrument/ev-group/ return strings correctly. These numerical values were then shown in the UI, as showcased in https://github.com/finmars-platform/finmars-core/issues/149#issuecomment-3896996252.

By marking portfolio_type as a relation, it now correctly shows the names when invoking this API endpoint.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/finmars-platform/finmars-core/pull/176 **Author:** [@HenkKalkwater](https://github.com/HenkKalkwater) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@paktusov](https://github.com/paktusov) **Base:** `main` ← **Head:** `add-portfolio-type-attr-to-relation-set` --- ### 📝 Commits (1) - [`6ceaa54`](https://github.com/finmars-platform/finmars-core/commit/6ceaa546ae3ea4fd014d3478ca92ea6b45560974) utils/attr_is_relation: add portfolio_type to relation set ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `poms/common/utils.py` (+1 -0) </details> ### 📄 Description /api/v1/portfolios/portfolio/ev-group/ returned `group_name` and `group_identifier` as numbers instead of strings. Other endpoints, like /api/v1/instruments/instrument/ev-group/ return strings correctly. These numerical values were then shown in the UI, as showcased in https://github.com/finmars-platform/finmars-core/issues/149#issuecomment-3896996252. By marking `portfolio_type` as a relation, it now correctly shows the names when invoking this API endpoint. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>