[PR #100] [MERGED] Plat-1149 fix and refac utils.py & add tests #160

New issue

Closed

opened 2026-03-03 11:59:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 11:59:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/finmars-platform/finmars-core/pull/100
Author: @sokolovdp
Created: 9/15/2025
Status: ✅ Merged
Merged: 10/16/2025
Merged by: @paktusov

Base: main ← Head: PLAT-1149

📝 Commits (10+)

857d8b8 PLAT-1149 refac
92c6cf5 PLAT-1149 refac
a85243b PLAT-1149 refac
276be7c PLAT-1149 refac
c08f52e PLAT-1149 refac
a765a8f PLAT-1149 refac
03c5d29 PLAT-1149 refac
8e76b6b PLAT-1149 refac
dfcc76f Merge branch 'main' into PLAT-1149
d8c5400 PLAT-1149 refac

📊 Changes

18 files changed (+3291 additions, -404 deletions)

View changed files

📝 .github/workflows/other.yml (+3 -0)
📝 poms/api/serializers.py (+3 -3)
📝 poms/api/views.py (+10 -10)
➕ poms/common/tests/test_calc_period_date.py (+541 -0)
➕ poms/common/tests/test_date_range_split_updated.py (+1463 -0)
➕ poms/common/tests/test_get_last_business_day_in_previous_quarter.py (+18 -0)
➕ poms/common/tests/test_get_last_business_day_of_previous_month.py (+18 -0)
➕ poms/common/tests/test_get_last_business_day_of_previous_year.py (+18 -0)
➕ poms/common/tests/test_get_list_of_dates_between_two_dates.py (+16 -0)
➕ poms/common/tests/test_pick_dates_from_range.py (+393 -0)
➕ poms/common/tests/test_split_date_range.py (+643 -0)
➖ poms/common/tests/test_utils.py (+0 -170)
📝 poms/common/utils.py (+154 -211)
📝 poms/expressions_engine/functions.py (+1 -1)
📝 poms/instruments/models.py (+2 -2)
📝 poms/instruments/tasks.py (+2 -1)
📝 poms/reports/performance_report.py (+4 -4)
📝 poms/transactions/models.py (+2 -2)

📄 Description

Proposed contribute solution to task https://github.com/finmars-platform/finmars-core/issues/25

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/finmars-platform/finmars-core/pull/100 **Author:** [@sokolovdp](https://github.com/sokolovdp) **Created:** 9/15/2025 **Status:** ✅ Merged **Merged:** 10/16/2025 **Merged by:** [@paktusov](https://github.com/paktusov) **Base:** `main` ← **Head:** `PLAT-1149` --- ### 📝 Commits (10+) - [`857d8b8`](https://github.com/finmars-platform/finmars-core/commit/857d8b8130c60b3a672f8dcf83fe776bad8a9832) PLAT-1149 refac - [`92c6cf5`](https://github.com/finmars-platform/finmars-core/commit/92c6cf5f902334dd9f382e9675cd217e535eac34) PLAT-1149 refac - [`a85243b`](https://github.com/finmars-platform/finmars-core/commit/a85243b4018f2048f0817e44176fc4bb05387e18) PLAT-1149 refac - [`276be7c`](https://github.com/finmars-platform/finmars-core/commit/276be7ca8bca901bc99dd9e315d7a11889dce2a7) PLAT-1149 refac - [`c08f52e`](https://github.com/finmars-platform/finmars-core/commit/c08f52e9ff947daf0f4aa8e022ab690e45b05922) PLAT-1149 refac - [`a765a8f`](https://github.com/finmars-platform/finmars-core/commit/a765a8f8fa10e3ef9e278713a7abbea3637f9fc8) PLAT-1149 refac - [`03c5d29`](https://github.com/finmars-platform/finmars-core/commit/03c5d298ec0a544656e4319f9181ebbbca2497c6) PLAT-1149 refac - [`8e76b6b`](https://github.com/finmars-platform/finmars-core/commit/8e76b6bf1b35c0141cdada40886e564d419d91d7) PLAT-1149 refac - [`dfcc76f`](https://github.com/finmars-platform/finmars-core/commit/dfcc76fcaaf015069c3051646d47f3001e69d5d1) Merge branch 'main' into PLAT-1149 - [`d8c5400`](https://github.com/finmars-platform/finmars-core/commit/d8c54008a38c77c773610707f6d82ded84faabb1) PLAT-1149 refac ### 📊 Changes **18 files changed** (+3291 additions, -404 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/other.yml` (+3 -0) 📝 `poms/api/serializers.py` (+3 -3) 📝 `poms/api/views.py` (+10 -10) ➕ `poms/common/tests/test_calc_period_date.py` (+541 -0) ➕ `poms/common/tests/test_date_range_split_updated.py` (+1463 -0) ➕ `poms/common/tests/test_get_last_business_day_in_previous_quarter.py` (+18 -0) ➕ `poms/common/tests/test_get_last_business_day_of_previous_month.py` (+18 -0) ➕ `poms/common/tests/test_get_last_business_day_of_previous_year.py` (+18 -0) ➕ `poms/common/tests/test_get_list_of_dates_between_two_dates.py` (+16 -0) ➕ `poms/common/tests/test_pick_dates_from_range.py` (+393 -0) ➕ `poms/common/tests/test_split_date_range.py` (+643 -0) ➖ `poms/common/tests/test_utils.py` (+0 -170) 📝 `poms/common/utils.py` (+154 -211) 📝 `poms/expressions_engine/functions.py` (+1 -1) 📝 `poms/instruments/models.py` (+2 -2) 📝 `poms/instruments/tasks.py` (+2 -1) 📝 `poms/reports/performance_report.py` (+4 -4) 📝 `poms/transactions/models.py` (+2 -2) </details> ### 📄 Description Proposed contribute solution to task https://github.com/finmars-platform/finmars-core/issues/25 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>