mirror of
https://github.com/artiebits/fake-git-history.git
synced 2026-04-26 15:35:58 +03:00
[GH-ISSUE #21] Success 0 commits have been created #6
Labels
No labels
good first issue
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/fake-git-history#6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rahulxdd on GitHub (Nov 3, 2020).
Original GitHub issue: https://github.com/artiebits/fake-git-history/issues/21
After I run this command
npx fake-git-history --commitsPerDay "0,5" --startDate "2019/12/31" --endDate "2019/05/30"I get this message:
Success 0 commits have been created. │ │ If you rely on this tool, please consider buying me a cup of coffee. I would appreciate it │ │ https://www.buymeacoffee.com/artiebitsCould you tell me what is the problem here?
@artiebits commented on GitHub (Nov 3, 2020):
hi @rahulxdd, thank you for opening the issue! could you try to swap start and end dates please?
npx fake-git-history --commitsPerDay "0,5" --startDate "2019/05/30" --endDate "2019/12/31". let me know if it helped@rahulxdd commented on GitHub (Nov 4, 2020):
It worked this time. I noticed a couple more things.
If you want me to create a video of how and what I am doing to get these results I can do that. Please let me know.
@artiebits commented on GitHub (Nov 5, 2020):
would be nice to see the video of how and what you are doing, thank you
@arinsanghia commented on GitHub (Nov 8, 2020):
currently, it is not working
@artiebits commented on GitHub (Nov 8, 2020):
@arinsanghia could you show me please what command you run?
@rahulxdd commented on GitHub (Nov 13, 2020):
hi again... sorry I took more time to record this video and send it to you. Here it is: https://www.loom.com/share/7b53ae2015d24a64854f9b4c29f8c8e4
Please take a look at let me know if you can fix it.
@artiebits commented on GitHub (Nov 16, 2020):
hi @rahulxdd,
thank you very much for the video that clearly shows the bug. I will take a look and come back to you
@rahulxdd commented on GitHub (Nov 16, 2020):
Thanks, can't wait.
@quentingosset commented on GitHub (Nov 19, 2020):
I had the same problem with values like 5.10 I had a maximum of 3 daily commits. I think it's a problem with the await and the exec. I solved the problem on my side with my Fork.
And i have send a PR : https://github.com/artiebits/fake-git-history/pull/22
@rahulxdd commented on GitHub (Nov 19, 2020):
Have you also checked the issues that I mentioned in the reply at the top and also in the video? And did you try checking the commit history when not logged in(for both private and public repo)?
@quentingosset commented on GitHub (Nov 19, 2020):
for my part, the commits all had correctly different dates. I didn't need to test directly on github, I just used "git log" over a period of 1 day with a random between 5 and 10 commits and the result was that in my commit array I had 8 different dates correctly but in the git history I had only 3 commits. I calllbacked the exec() function errors and I found that on my 8 commits in my array in the loop at some point I had 6 error calllbacks. This is why I suspected a problem with the await sleep(150); which returns a single Promise. To avoid problems in my PR I made EVERY exec() command a Promise to make sure it executed.
@artiebits commented on GitHub (Nov 20, 2020):
hi @rahulxdd
I have published a beta version
1.4.0-beta.0with a fix from @quentingosset. Looks like it solves your issue. Could you try it please?npx fake-git-history@1.4.0-beta.0 -s "2020/09/01" -e "2020/09/30" -c "3,5". Thank you@rahulxdd commented on GitHub (Nov 20, 2020):
@artiebits just checked 3 times. The number of commits are working fine but when I try to check the commit history from a private window it doesn't show anything. Can this fixed? @artiebits & @quentingosset
@quentingosset commented on GitHub (Nov 20, 2020):
It's not a problem related on this script but it's a setttings on github ;)
Enjoy.
@rahulxdd commented on GitHub (Nov 20, 2020):
@quentingosset you're right. I think @artiebits can merge the updated code now. Thanks for all the help. :)
@artiebits commented on GitHub (Nov 20, 2020):
I have released version 1.4.0, thank you both!