[PR #25] [MERGED] Fix Windows user can't remove the folder and generate formatted datetime #44

Closed
opened 2026-03-02 02:53:12 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/artiebits/fake-git-history/pull/25
Author: @ikr4-m
Created: 5/29/2021
Status: Merged
Merged: 5/30/2021
Merged by: @artiebits

Base: masterHead: master


📝 Commits (3)

  • 077dfa6 Fix delete command when user in Windows
  • 333dff3 Change spinner
  • 543ba26 Fix force rmdir for Windows

📊 Changes

2 files changed (+18 additions, -3 deletions)

View changed files

📝 src/index.js (+17 -2)
📝 yarn.lock (+1 -1)

📄 Description

I've just using your code in Windows and see some command cannot run in Windows. So, I've fix that command will running if the my-history folder is exists and add rmdir command for Windows.

Also, I add some formatted datetime to see the progress of this code.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/artiebits/fake-git-history/pull/25 **Author:** [@ikr4-m](https://github.com/ikr4-m) **Created:** 5/29/2021 **Status:** ✅ Merged **Merged:** 5/30/2021 **Merged by:** [@artiebits](https://github.com/artiebits) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`077dfa6`](https://github.com/artiebits/fake-git-history/commit/077dfa67aca11f724e4211f15d048f102560734b) Fix delete command when user in Windows - [`333dff3`](https://github.com/artiebits/fake-git-history/commit/333dff35893db416812a11f95215b72b7e80d8d0) Change spinner - [`543ba26`](https://github.com/artiebits/fake-git-history/commit/543ba26e3547316037abdd9768ee57bbc5464076) Fix force rmdir for Windows ### 📊 Changes **2 files changed** (+18 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/index.js` (+17 -2) 📝 `yarn.lock` (+1 -1) </details> ### 📄 Description I've just using your code in Windows and see some command cannot run in Windows. So, I've fix that command will running if the `my-history` folder is exists and add `rmdir` command for Windows. Also, I add some formatted datetime to see the progress of this code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 02:53:12 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-git-history#44
No description provided.