[PR #22] [MERGED] Implementation of the exec() call in Promise mode #41

New issue

kerem · 2026-03-02T02:53:11+03:00

kerem commented

2026-03-02 02:53:11 +03:00

📋 Pull Request Information

Original PR: https://github.com/artiebits/fake-git-history/pull/22
Author: @quentingosset
Created: 11/18/2020
Status: ✅ Merged
Merged: 11/20/2020
Merged by: @artiebits

Base: master ← Head: patch-1

📝 Commits (1)

586b322 Implementation of the exec() call in Promise mode

📊 Changes

1 file changed (+20 additions, -4 deletions)

View changed files

📝 src/index.js (+20 -4)

📄 Description

I don't know why I had this problem, but I noticed that I always had a limit of 1 to 3 commits for each day using the --commitsPerDay option "5,10" (see screen) however in the debug the value commitsPerDay was always higher than 3 and in the commit creation loop there were the X commits sent. however during a "git log" only 3 commits maximum per day were present. So I suspect a problem with the exec() and the waiting of 150. I solved the problem by using an exec in Promise mode.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/artiebits/fake-git-history/pull/22 **Author:** [@quentingosset](https://github.com/quentingosset) **Created:** 11/18/2020 **Status:** ✅ Merged **Merged:** 11/20/2020 **Merged by:** [@artiebits](https://github.com/artiebits) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`586b322`](https://github.com/artiebits/fake-git-history/commit/586b322b1a683203a08cdf0bdaa1abd1b0726ea1) Implementation of the exec() call in Promise mode ### 📊 Changes **1 file changed** (+20 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/index.js` (+20 -4) </details> ### 📄 Description I don't know why I had this problem, but I noticed that I always had a limit of 1 to 3 commits for each day using the --commitsPerDay option "5,10" (see screen) however in the debug the value commitsPerDay was always higher than 3 and in the commit creation loop there were the X commits sent. however during a "git log" only 3 commits maximum per day were present. So I suspect a problem with the exec() and the waiting of 150. I solved the problem by using an exec in Promise mode. ![image](https://user-images.githubusercontent.com/6824137/99575694-452ab180-29d9-11eb-9fd2-477a94790c58.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 02:53:11 +03:00