[PR #1] [MERGED] Fix infinite spinner #27

New issue

kerem · 2026-03-02T02:53:08+03:00

kerem commented

2026-03-02 02:53:08 +03:00

📋 Pull Request Information

Original PR: https://github.com/artiebits/fake-git-history/pull/1
Author: @itsabdelrahman
Created: 8/21/2019
Status: ✅ Merged
Merged: 8/22/2019
Merged by: @artiebits

Base: master ← Head: hotfix/exec

📝 Commits (1)

e0d6869 Execute shell command once

📊 Changes

1 file changed (+6 additions, -9 deletions)

View changed files

📝 index.js (+6 -9)

📄 Description

Fixes #2.

A potential solution is joining all the git commands into a single long command and running it once asynchronously. This guarantees that the commands run individually in sequence (and therefore without race conditions), but also collectively run in an asynchronous fashion so that the spinner doesn't freeze. Here it is in action:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/artiebits/fake-git-history/pull/1 **Author:** [@itsabdelrahman](https://github.com/itsabdelrahman) **Created:** 8/21/2019 **Status:** ✅ Merged **Merged:** 8/22/2019 **Merged by:** [@artiebits](https://github.com/artiebits) **Base:** `master` ← **Head:** `hotfix/exec` --- ### 📝 Commits (1) - [`e0d6869`](https://github.com/artiebits/fake-git-history/commit/e0d6869135c1bfccbd1326b49fcb2f6b4f619d4c) Execute shell command once ### 📊 Changes **1 file changed** (+6 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `index.js` (+6 -9) </details> ### 📄 Description Fixes #2. A potential solution is joining all the git commands into a single long command and running it once asynchronously. This guarantees that the commands run individually in sequence (and therefore without race conditions), but also collectively run in an asynchronous fashion so that the spinner doesn't freeze. Here it is in action: <img width="1393" alt="Screen Shot 2019-08-22 at 01 55 23" src="https://user-images.githubusercontent.com/11808903/63476100-f31a7980-c47f-11e9-8849-4a6a9b8f9914.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 02:53:08 +03:00