[PR #845] [Draft] Fix resumable upload #967

Open
opened 2026-03-03 12:32:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/845
Author: @barathsriram
Created: 6/29/2022
Status: 🔄 Open

Base: mainHead: fix-resumable-upload


📝 Commits (2)

  • b102df2 Fix resumable upload
  • 597dd2c Merge branch 'fsouza:main' into fix-resumable-upload

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 fakestorage/server.go (+1 -0)
📝 fakestorage/upload.go (+4 -3)

📄 Description

This is a work-in-progress PR that intends to fix https://github.com/fsouza/fake-gcs-server/issues/532 and https://github.com/fsouza/fake-gcs-server/issues/623

Changes:

  1. Fix the Resumable upload URL to match Google's API URL
  2. Retrieve upload_id from query parameter

TODO:

  • Fix any existing test failures
  • Add new tests for the changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/845 **Author:** [@barathsriram](https://github.com/barathsriram) **Created:** 6/29/2022 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-resumable-upload` --- ### 📝 Commits (2) - [`b102df2`](https://github.com/fsouza/fake-gcs-server/commit/b102df2f6041cdbced5c145ff64259825264c852) Fix resumable upload - [`597dd2c`](https://github.com/fsouza/fake-gcs-server/commit/597dd2ce1e9b45a607aab936d2d1de00e6d0dc9f) Merge branch 'fsouza:main' into fix-resumable-upload ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/server.go` (+1 -0) 📝 `fakestorage/upload.go` (+4 -3) </details> ### 📄 Description This is a work-in-progress PR that intends to fix https://github.com/fsouza/fake-gcs-server/issues/532 and https://github.com/fsouza/fake-gcs-server/issues/623 **Changes:** 1. Fix the Resumable upload URL to match Google's API URL 2. Retrieve `upload_id` from query parameter **TODO:** - [ ] Fix any existing test failures - [ ] Add new tests for the changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#967
No description provided.