mirror of
https://github.com/fsouza/fake-gcs-server.git
synced 2026-04-27 14:45:49 +03:00
[GH-ISSUE #494] [Feature request] Support HTTP connections in container #96
Labels
No labels
bug
compatibility-issue
docker
documentation
enhancement
help wanted
needs information
pull-request
question
stale
unfortunate
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/fake-gcs-server#96
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aochagavia on GitHub (May 6, 2021).
Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/494
Problem
The
Dockerfileonly exposes an HTTPS port for connections, as you can see below:github.com/fsouza/fake-gcs-server@4fd6c95bc5/Dockerfile (L13-L17)While using HTTPS is not a problem when testing things using curl, it doesn't work well when using the SDK for C# (it refuses to establish a HTTPS connection without a valid certificate).
Proposed solution
Exposing an HTTP port would make it possible to use this project together with the C# SDK.
Btw, I looked around the code to see if it was easy to add, but I am not acquainted enough with Go and got lost :/
@fsouza commented on GitHub (May 7, 2021):
Hi @aochagavia, thanks for opening this issue. The
EXPOSEcommand in Docker is mostly for documentation and some level of automation when publishing ports, you can publish any ports when starting the container, and fake-gcs-server already supports running with http instead of https, as long as you specify the-schemeflag.So, adapting the example in the readme to use http + port 8080 would be something like:
(port 4443 can be used with http too, it doesn't need to be used with https, so you could pass just
-scheme httpandcurl http://0.0.0.0:4443/...instead)@aochagavia commented on GitHub (May 7, 2021):
Hi @fsouza , thanks for the explanation. It seems like I missed the
-schemeflag. Maybe it would be useful to have it mentioned on the readme.By the way, thanks for this repository as well!
@fsouza commented on GitHub (May 7, 2021):
Oh, that's a good callout. Let me reopen this so we can track the doc change.