[PR #818] [CLOSED] Revert partial support for generations in the filesystem backend #942

New issue

Closed

opened 2026-03-03 12:32:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:32:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/818
Author: @fsouza
Created: 6/6/2022
Status: ❌ Closed

Base: main ← Head: generation-changes

📝 Commits (2)

3f967e7 Revert "internal/backend: fs storage generates the destination now"
dc840a5 Revert "backend/fs: set object Generation when creating the object"

📊 Changes

2 files changed (+4 additions, -8 deletions)

View changed files

📝 internal/backend/backend_test.go (+4 -1)
📝 internal/backend/fs.go (+0 -7)

📄 Description

The original fix released in 1.38.1 caused a regression (see #816).

Turns out we can't support generation partially: it has to come with versioning. Anyone needing support for generations for now has to use the memory backend, the only backend that supports versioning at the moment.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/818 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 6/6/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `generation-changes` --- ### 📝 Commits (2) - [`3f967e7`](https://github.com/fsouza/fake-gcs-server/commit/3f967e758a0afc5d6f72bb66a52b9951c3ca26a8) Revert "internal/backend: fs storage generates the destination now" - [`dc840a5`](https://github.com/fsouza/fake-gcs-server/commit/dc840a57bd725d22afc2015f5862872d91c1fed9) Revert "backend/fs: set object Generation when creating the object" ### 📊 Changes **2 files changed** (+4 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `internal/backend/backend_test.go` (+4 -1) 📝 `internal/backend/fs.go` (+0 -7) </details> ### 📄 Description The original fix released in 1.38.1 caused a regression (see #816). Turns out we can't support generation partially: it has to come with versioning. Anyone needing support for generations for now has to use the memory backend, the only backend that supports versioning at the moment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>