[PR #784] [MERGED] Fix comment to match routing #914

New issue

Closed

opened 2026-03-03 12:32:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:32:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/784
Author: @StevenACoffman
Created: 5/13/2022
Status: ✅ Merged
Merged: 5/13/2022
Merged by: @fsouza

Base: main ← Head: patch-1

📝 Commits (1)

6888bce Fix comment to match routing

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 fakestorage/server.go (+1 -1)

📄 Description

I think this comment will now better reflect this routing:

s.mux.Host(bucketHost).Path("/{objectName:.+}").Methods(http.MethodGet, http.MethodHead).HandlerFunc(s.downloadObject)
s.mux.Host(bucketHost).Path("/{objectName:.+}").Methods(http.MethodPost, http.MethodPut).HandlerFunc(jsonToHTTPHandler(s.insertObject))

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/784 **Author:** [@StevenACoffman](https://github.com/StevenACoffman) **Created:** 5/13/2022 **Status:** ✅ Merged **Merged:** 5/13/2022 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`6888bce`](https://github.com/fsouza/fake-gcs-server/commit/6888bceb9e925d2008527f0ac0ec19bf31d20444) Fix comment to match routing ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/server.go` (+1 -1) </details> ### 📄 Description I think this comment will now better reflect [this routing](https://github.com/fsouza/fake-gcs-server/blob/main/fakestorage/server.go#L266): ``` s.mux.Host(bucketHost).Path("/{objectName:.+}").Methods(http.MethodGet, http.MethodHead).HandlerFunc(s.downloadObject) s.mux.Host(bucketHost).Path("/{objectName:.+}").Methods(http.MethodPost, http.MethodPut).HandlerFunc(jsonToHTTPHandler(s.insertObject)) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>