mirror of
https://github.com/fsouza/fake-gcs-server.git
synced 2026-04-25 21:55:56 +03:00
[PR #736] [MERGED] Add signed URL setup instructions in README #870
Labels
No labels
bug
compatibility-issue
docker
documentation
enhancement
help wanted
needs information
pull-request
question
stale
unfortunate
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/fake-gcs-server#870
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/fsouza/fake-gcs-server/pull/736
Author: @toadjaune
Created: 4/5/2022
Status: ✅ Merged
Merged: 4/6/2022
Merged by: @fsouza
Base:
main← Head:add-signed-url-readme📝 Commits (4)
dbc43a0Add signed URL setup instructions in README8617382Update formatting in README.mdd281674Update README.md8f366cdA bit of word smithing📊 Changes
1 file changed (+10 additions, -0 deletions)
View changed files
📝
README.md(+10 -0)📄 Description
Hi !
First of all, thanks for providing this project ! It proved very useful :)
I found however the documentation on the required setup for use with signed URLs insufficient, and had to dig quite a bit in the code to understand how to make it work.
Here's a minimal doc addition explaining how to do it.
You might want to change the structure, such as adding it out of the docker section instead, including it in code samples, etc ...
Related issues : https://github.com/fsouza/fake-gcs-server/issues/631 https://github.com/fsouza/fake-gcs-server/issues/537
Closes #631.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.