[PR #735] [MERGED] upload: add support for precondition headers #868

New issue

Closed

opened 2026-03-03 12:32:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:32:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/735
Author: @tymeshifter
Created: 4/4/2022
Status: ✅ Merged
Merged: 4/5/2022
Merged by: @fsouza

Base: main ← Head: aj/add-support-for-preconditions

📝 Commits (1)

b59be81 upload: add support for precondition headers

📊 Changes

3 files changed (+166 additions, -7 deletions)

View changed files

📝 fakestorage/upload.go (+43 -6)
📝 fakestorage/upload_test.go (+122 -0)
📝 internal/backend/memory.go (+1 -1)

📄 Description

Added support for:

ifGenerationMatch
ifGenerationNotMatch

Without this support I am experiencing issues described in https://github.com/googleapis/google-cloud-go/issues/1624#issuecomment-1081701913

Relates to https://github.com/fsouza/fake-gcs-server/issues/299

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/735 **Author:** [@tymeshifter](https://github.com/tymeshifter) **Created:** 4/4/2022 **Status:** ✅ Merged **Merged:** 4/5/2022 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `aj/add-support-for-preconditions` --- ### 📝 Commits (1) - [`b59be81`](https://github.com/fsouza/fake-gcs-server/commit/b59be81ab8448130456b8f1132e1947e7f37309d) upload: add support for precondition headers ### 📊 Changes **3 files changed** (+166 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/upload.go` (+43 -6) 📝 `fakestorage/upload_test.go` (+122 -0) 📝 `internal/backend/memory.go` (+1 -1) </details> ### 📄 Description Added support for: - ifGenerationMatch - ifGenerationNotMatch Without this support I am experiencing issues described in https://github.com/googleapis/google-cloud-go/issues/1624#issuecomment-1081701913 Relates to https://github.com/fsouza/fake-gcs-server/issues/299 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>