[PR #728] [MERGED] server: make publicHostMatcher backwards compatible with gorilla/mux #862

Closed
opened 2026-03-03 12:31:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/728
Author: @fsouza
Created: 3/25/2022
Status: Merged
Merged: 3/26/2022
Merged by: @fsouza

Base: mainHead: fix-host-validation


📝 Commits (2)

  • ca00a1c server: make publicHostMatcher backwards compatible with gorilla/mux
  • c1b343b server: better hostname validation

📊 Changes

2 files changed (+67 additions, -5 deletions)

View changed files

📝 fakestorage/server.go (+5 -1)
📝 fakestorage/server_test.go (+62 -4)

📄 Description

Fixes #713.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/728 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 3/25/2022 **Status:** ✅ Merged **Merged:** 3/26/2022 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `fix-host-validation` --- ### 📝 Commits (2) - [`ca00a1c`](https://github.com/fsouza/fake-gcs-server/commit/ca00a1ca719f052a58bb6fb9664e8909486b20b9) server: make publicHostMatcher backwards compatible with gorilla/mux - [`c1b343b`](https://github.com/fsouza/fake-gcs-server/commit/c1b343b162b2dd4976f5506f2067e2c3334a3246) server: better hostname validation ### 📊 Changes **2 files changed** (+67 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/server.go` (+5 -1) 📝 `fakestorage/server_test.go` (+62 -4) </details> ### 📄 Description Fixes #713. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:31:57 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#862
No description provided.