[PR #712] [MERGED] enable updating of publicHost through server config #850

Closed
opened 2026-03-03 12:31:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/712
Author: @majelbstoat
Created: 3/10/2022
Status: Merged
Merged: 3/10/2022
Merged by: @fsouza

Base: mainHead: jamie/update-public-host


📝 Commits (2)

  • 910e099 enable updating of publicHost through server config
  • 5bb1d90 add a confirming test

📊 Changes

3 files changed (+75 additions, -4 deletions)

View changed files

📝 fakestorage/config.go (+5 -0)
📝 fakestorage/server.go (+9 -4)
📝 fakestorage/server_test.go (+61 -0)

📄 Description

Potentially fixes https://github.com/fsouza/fake-gcs-server/issues/711


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/712 **Author:** [@majelbstoat](https://github.com/majelbstoat) **Created:** 3/10/2022 **Status:** ✅ Merged **Merged:** 3/10/2022 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `jamie/update-public-host` --- ### 📝 Commits (2) - [`910e099`](https://github.com/fsouza/fake-gcs-server/commit/910e099149d64363436d01bc4a8d458523b33bcd) enable updating of publicHost through server config - [`5bb1d90`](https://github.com/fsouza/fake-gcs-server/commit/5bb1d90514109aa0ff253db4e76971a8f6820b0d) add a confirming test ### 📊 Changes **3 files changed** (+75 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/config.go` (+5 -0) 📝 `fakestorage/server.go` (+9 -4) 📝 `fakestorage/server_test.go` (+61 -0) </details> ### 📄 Description Potentially fixes https://github.com/fsouza/fake-gcs-server/issues/711 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:31:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#850
No description provided.