[PR #699] [MERGED] Object metadata should be optional in resumable uploads #332 #839

New issue

Closed

opened 2026-03-03 12:31:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:31:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/699
Author: @martinzink
Created: 3/1/2022
Status: ✅ Merged
Merged: 3/8/2022
Merged by: @fsouza

Base: main ← Head: fix_cpp_bugs

📝 Commits (5)

d54f2c9 Object metadata should be optional in resumable uploads #332
997fab9 Update fakestorage/upload.go
1113804 added cpp to ci
1da79bd change google-cloud-cpp to release v1.37.0
8fe5502 retain err check with smaller scope

📊 Changes

7 files changed (+140 additions, -56 deletions)

View changed files

📝 .github/workflows/main.yml (+3 -0)
➕ ci/run-cpp-example.sh (+13 -0)
➕ examples/cpp/.gitignore (+1 -0)
➕ examples/cpp/CMakeLists.txt (+31 -0)
➕ examples/cpp/cpp-examples.cpp (+26 -0)
📝 fakestorage/upload.go (+7 -3)
📝 fakestorage/upload_test.go (+59 -53)

📄 Description

We are working on google-cloud integration for our project Apache Nifi Minifi CPP and fake-gcs-server seems to be an awesome way to create integration tests.
However I encountered some issues, which made impossible to integrate fake-gcs-server with a C++ app

I already fixed the issues from google-cloud-cpp's side
https://github.com/googleapis/google-cloud-cpp/pull/8446
https://github.com/googleapis/google-cloud-cpp/pull/8477

The last issue that blocks using fake-gcs-server with a cpp application seems to be #332
As described in the issue fake-gcs-server is stricter than google cloud storage when it comes to resumable upload requests.
With this PR the object metadata is optional when creating a resumable upload request.

I also added cpp examples so it can be verified that the resumable uploads are working now with fake-gcs-server.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/699 **Author:** [@martinzink](https://github.com/martinzink) **Created:** 3/1/2022 **Status:** ✅ Merged **Merged:** 3/8/2022 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `fix_cpp_bugs` --- ### 📝 Commits (5) - [`d54f2c9`](https://github.com/fsouza/fake-gcs-server/commit/d54f2c9b3d2cfb9de00282e4884e2779ae52808d) Object metadata should be optional in resumable uploads #332 - [`997fab9`](https://github.com/fsouza/fake-gcs-server/commit/997fab90ca5b7c49efa4c7f4bdaea656807e7c52) Update fakestorage/upload.go - [`1113804`](https://github.com/fsouza/fake-gcs-server/commit/1113804c997f0241ac1824fdeacf4b326ea2a580) added cpp to ci - [`1da79bd`](https://github.com/fsouza/fake-gcs-server/commit/1da79bd18749ce8e35deae56c2edbf565c289aa0) change google-cloud-cpp to release v1.37.0 - [`8fe5502`](https://github.com/fsouza/fake-gcs-server/commit/8fe55026b46c1a9122637c6a6d715ba05a8bcc36) retain err check with smaller scope ### 📊 Changes **7 files changed** (+140 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/main.yml` (+3 -0) ➕ `ci/run-cpp-example.sh` (+13 -0) ➕ `examples/cpp/.gitignore` (+1 -0) ➕ `examples/cpp/CMakeLists.txt` (+31 -0) ➕ `examples/cpp/cpp-examples.cpp` (+26 -0) 📝 `fakestorage/upload.go` (+7 -3) 📝 `fakestorage/upload_test.go` (+59 -53) </details> ### 📄 Description We are working on google-cloud integration for our project [Apache Nifi Minifi CPP](https://github.com/apache/nifi-minifi-cpp) and fake-gcs-server seems to be an awesome way to create integration tests. However I encountered some issues, which made impossible to integrate fake-gcs-server with a C++ app I already fixed the issues from google-cloud-cpp's side https://github.com/googleapis/google-cloud-cpp/pull/8446 https://github.com/googleapis/google-cloud-cpp/pull/8477 The last issue that blocks using fake-gcs-server with a cpp application seems to be #332 As described in the issue fake-gcs-server is stricter than google cloud storage when it comes to resumable upload requests. With this PR the object metadata is optional when creating a resumable upload request. I also added cpp examples so it can be verified that the resumable uploads are working now with fake-gcs-server. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>