starred/fake-gcs-server

Fork 0

mirror of https://github.com/fsouza/fake-gcs-server.git synced 2026-04-25 21:55:56 +03:00

[GH-ISSUE #410] Setting blob.custom_time doesn't work, returns always None #79

New issue

Closed

opened 2026-03-03 12:08:05 +03:00 by kerem · 7 comments

kerem commented

2026-03-03 12:08:05 +03:00

Owner

Originally created by @oittaa on GitHub (Feb 4, 2021).
Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/410

I have a piece of code like the following:

self.client = storage.Client()
self.bucket = self.client.get_bucket(bucket_name)

blob = self.bucket.blob(blob_name)
blob.upload_from_string(value, content_type=content_type)
blob.reload()
blob.custom_time = datetime.datetime.now(datetime.timezone.utc)
blob.patch()

If I set custom_time before uploading, even the real Google server erases it from the blob. That's why I patch it after the upload. The fake server unfortunately loses it even after patch.

blob = self.bucket.get_blob(blob_name)
print(blob.custom_time)

results in None

Originally created by @oittaa on GitHub (Feb 4, 2021). Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/410 I have a piece of code like the following: ``` self.client = storage.Client() self.bucket = self.client.get_bucket(bucket_name) blob = self.bucket.blob(blob_name) blob.upload_from_string(value, content_type=content_type) blob.reload() blob.custom_time = datetime.datetime.now(datetime.timezone.utc) blob.patch() ``` If I set `custom_time` before uploading, even the real Google server erases it from the blob. That's why I patch it after the upload. The fake server unfortunately loses it even after `patch`. ``` blob = self.bucket.get_blob(blob_name) print(blob.custom_time) ``` results in `None`

kerem

2026-03-03 12:08:05 +03:00

closed this issue
added the
enhancement

help wanted
labels

kerem commented

2026-03-03 12:08:06 +03:00

Author

Owner

@oittaa commented on GitHub (Feb 5, 2021):

To me it looks like the Custom-Time is completely missing from objects. github.com/fsouza/fake-gcs-server@297b8cdcd2/fakestorage/object.go (L25-L43)

https://cloud.google.com/storage/docs/metadata#custom-time
https://pkg.go.dev/cloud.google.com/go/storage#ObjectAttrsToUpdate

@oittaa commented on GitHub (Feb 5, 2021): To me it looks like the `Custom-Time` is completely missing from objects. https://github.com/fsouza/fake-gcs-server/blob/297b8cdcd2f8fac8652f8b20c023ececb1c368b1/fakestorage/object.go#L25-L43 https://cloud.google.com/storage/docs/metadata#custom-time https://pkg.go.dev/cloud.google.com/go/storage#ObjectAttrsToUpdate

kerem commented

2026-03-03 12:08:06 +03:00

Author

Owner

@oittaa commented on GitHub (Feb 6, 2021):

The original Google Cloud issue about missing custom_time before patching is tracked here. https://github.com/googleapis/python-storage/issues/372

@oittaa commented on GitHub (Feb 6, 2021): The original Google Cloud issue about missing `custom_time` before patching is tracked here. https://github.com/googleapis/python-storage/issues/372

kerem commented

2026-03-03 12:08:06 +03:00

Author

Owner

@fsouza commented on GitHub (Feb 15, 2021):

Thanks for reporting and linking the docs!

@fsouza commented on GitHub (Feb 15, 2021): Thanks for reporting and linking the docs!

kerem commented

2026-03-03 12:08:06 +03:00

Author

Owner

@mar-pan commented on GitHub (Dec 23, 2022):

Hello @fsouza is there any chance that this could be assigned to someone and resolved? It looks like that Google resolved issue on their side and I can confirm that it works with "real" API

@mar-pan commented on GitHub (Dec 23, 2022): Hello @fsouza is there any chance that this could be assigned to someone and resolved? It looks like that Google resolved issue on their side and I can confirm that it works with "real" API

kerem commented

2026-03-03 12:08:06 +03:00

Author

Owner

@fsouza commented on GitHub (Dec 28, 2022):

I opened #1024 (big round-number!) as a draft, in case someone wants to work on it. It's unlikely I'll be able to pick it back up in the next couple of weeks.

@fsouza commented on GitHub (Dec 28, 2022): I opened #1024 (big round-number!) as a draft, in case someone wants to work on it. It's unlikely I'll be able to pick it back up in the next couple of weeks.

kerem commented

2026-03-03 12:08:06 +03:00

Author

Owner

@RachitSharma2001 commented on GitHub (Jan 7, 2023):

@fsouza I believe I have a solution that fixes this issue and updates CustomTime correctly. I am ready to submit a pr but since my solution is based off the changes I made to this PR (specifically the changes added to PatchObject method in object.go) I just want to make sure that those changes are good before submitting a pr to fix this issue.

@RachitSharma2001 commented on GitHub (Jan 7, 2023): @fsouza I believe I have a solution that fixes this issue and updates `CustomTime` correctly. I am ready to submit a pr but since my solution is based off the changes I made to [this](https://github.com/fsouza/fake-gcs-server/pull/1016) PR (specifically the changes added to `PatchObject` method in `object.go`) I just want to make sure that those changes are good before submitting a pr to fix this issue.

kerem commented

2026-03-03 12:08:06 +03:00

Author

Owner

@fsouza commented on GitHub (Jan 7, 2023):

@RachitSharma2001 hey, I'm going to look at your PR later today (in 2 hours or so). If you prefer, you can open another PR on top of that one, or we can wait.

Apologies for the delayed review.

@fsouza commented on GitHub (Jan 7, 2023): @RachitSharma2001 hey, I'm going to look at your PR later today (in 2 hours or so). If you prefer, you can open another PR on top of that one, or we can wait. Apologies for the delayed review.

kerem referenced this issue

2026-03-03 12:29:28 +03:00

[PR #79] [MERGED] build(deps): bump google-cloud-storage from 1.19.0 to 1.19.1 in /examples/python #321