[PR #490] [MERGED] Continuation of event support PR #655

New issue

Closed

opened 2026-03-03 12:31:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:31:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/490
Author: @terev
Created: 4/28/2021
Status: ✅ Merged
Merged: 12/29/2021
Merged by: @fsouza

Base: event-support-wip ← Head: event-support

📝 Commits (1)

54b8ecf Added support to send events to a pubsub topic

📊 Changes

9 files changed (+808 additions, -20 deletions)

View changed files

📝 fakestorage/object.go (+43 -3)
📝 fakestorage/server.go (+26 -13)
📝 fakestorage/server_test.go (+233 -0)
📝 go.mod (+7 -0)
📝 go.sum (+19 -0)
📝 internal/config/config.go (+72 -2)
📝 internal/config/config_test.go (+47 -2)
➕ internal/notification/event.go (+214 -0)
➕ internal/notification/event_test.go (+147 -0)

📄 Description

This pr is a continuation of PR #370 created by @isaldana . I hope its okay that I picked up this work. This would be a really great feature to have available. If this pr is accepted I want to make sure the work is attributed to @isaldana. I was sure to rebase that work to retain their commits.

I've addressed the comment left on his pr about moving event options to a separate struct. I've also made a few fixes including:

a typo in an option name
the event generated from object creations didn't include the metadata from the created object
the workaround for a gsutil cp issue discovered by @StephenWithPH here https://github.com/fsouza/fake-gcs-server/issues/217#issuecomment-679443353 . i have done some digging on the next error but have yet to discover a solution
Always add localhost route rule to ensure requests via another network (like docker bridge) succeed. addresses issue encountered in #280

@isaldana please feel free to veto this pr if you prefer i dont submit it on your behalf

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/490 **Author:** [@terev](https://github.com/terev) **Created:** 4/28/2021 **Status:** ✅ Merged **Merged:** 12/29/2021 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `event-support-wip` ← **Head:** `event-support` --- ### 📝 Commits (1) - [`54b8ecf`](https://github.com/fsouza/fake-gcs-server/commit/54b8ecfde8f1a94390db72c7c00e261839d94d98) Added support to send events to a pubsub topic ### 📊 Changes **9 files changed** (+808 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+43 -3) 📝 `fakestorage/server.go` (+26 -13) 📝 `fakestorage/server_test.go` (+233 -0) 📝 `go.mod` (+7 -0) 📝 `go.sum` (+19 -0) 📝 `internal/config/config.go` (+72 -2) 📝 `internal/config/config_test.go` (+47 -2) ➕ `internal/notification/event.go` (+214 -0) ➕ `internal/notification/event_test.go` (+147 -0) </details> ### 📄 Description This pr is a continuation of PR #370 created by @isaldana . I hope its okay that I picked up this work. This would be a really great feature to have available. If this pr is accepted I want to make sure the work is attributed to @isaldana. I was sure to rebase that work to retain their commits. I've addressed the comment left on his pr about moving event options to a separate struct. I've also made a few fixes including: - a typo in an option name - the event generated from object creations didn't include the metadata from the created object - the workaround for a gsutil cp issue discovered by @StephenWithPH here https://github.com/fsouza/fake-gcs-server/issues/217#issuecomment-679443353 . i have done some digging on the next error but have yet to discover a solution - Always add localhost route rule to ensure requests via another network (like docker bridge) succeed. addresses issue encountered in #280 @isaldana please feel free to veto this pr if you prefer i dont submit it on your behalf --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>