[PR #481] [MERGED] adds support for deleting buckets #647

New issue

Closed

opened 2026-03-03 12:30:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:30:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/481
Author: @joerodriguez
Created: 4/19/2021
Status: ✅ Merged
Merged: 4/24/2021
Merged by: @fsouza

Base: main ← Head: delete-bucket-support

📝 Commits (1)

1e39dd0 adds support for deleting buckets

📊 Changes

7 files changed (+110 additions, -11 deletions)

View changed files

📝 fakestorage/bucket.go (+17 -0)
📝 fakestorage/bucket_test.go (+44 -0)
📝 fakestorage/server.go (+1 -0)
📝 internal/backend/backend_test.go (+9 -11)
📝 internal/backend/fs.go (+15 -0)
📝 internal/backend/memory.go (+16 -0)
📝 internal/backend/storage.go (+8 -0)

📄 Description

This PR adds support for deleting buckets with the gcs client. I do not know the full set of preconditions for deleting a bucket, but GCS does require the bucket to be empty, which is respected here.

This fixes https://github.com/fsouza/fake-gcs-server/issues/214

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/481 **Author:** [@joerodriguez](https://github.com/joerodriguez) **Created:** 4/19/2021 **Status:** ✅ Merged **Merged:** 4/24/2021 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `delete-bucket-support` --- ### 📝 Commits (1) - [`1e39dd0`](https://github.com/fsouza/fake-gcs-server/commit/1e39dd0516c55f289c5ac008c148f7cba415b9df) adds support for deleting buckets ### 📊 Changes **7 files changed** (+110 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/bucket.go` (+17 -0) 📝 `fakestorage/bucket_test.go` (+44 -0) 📝 `fakestorage/server.go` (+1 -0) 📝 `internal/backend/backend_test.go` (+9 -11) 📝 `internal/backend/fs.go` (+15 -0) 📝 `internal/backend/memory.go` (+16 -0) 📝 `internal/backend/storage.go` (+8 -0) </details> ### 📄 Description This PR adds support for deleting buckets with the gcs client. I do not know the full set of preconditions for deleting a bucket, but GCS does require the bucket to be empty, which is respected here. This fixes https://github.com/fsouza/fake-gcs-server/issues/214 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>