[PR #460] [MERGED] fakestorage: refactor how content-type is handled #630

Closed
opened 2026-03-03 12:30:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/460
Author: @fsouza
Created: 3/21/2021
Status: Merged
Merged: 3/21/2021
Merged by: @fsouza

Base: mainHead: better-content-type-header


📝 Commits (2)

  • bf8a250 fakestorage: refactor how content-type is handled
  • 786e1fb fakestorage: use a string to represent errors in jsonResponse

📊 Changes

5 files changed (+204 additions, -197 deletions)

View changed files

📝 fakestorage/bucket.go (+12 -28)
fakestorage/json_response.go (+55 -0)
📝 fakestorage/object.go (+56 -66)
📝 fakestorage/server.go (+15 -15)
📝 fakestorage/upload.go (+66 -88)

📄 Description

Also improves error reporting.

Closes #456.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/460 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 3/21/2021 **Status:** ✅ Merged **Merged:** 3/21/2021 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `better-content-type-header` --- ### 📝 Commits (2) - [`bf8a250`](https://github.com/fsouza/fake-gcs-server/commit/bf8a2509c94e9068cda622115a0504aaf93de153) fakestorage: refactor how content-type is handled - [`786e1fb`](https://github.com/fsouza/fake-gcs-server/commit/786e1fb8d78e66422ed0398290adac978ff66a52) fakestorage: use a string to represent errors in jsonResponse ### 📊 Changes **5 files changed** (+204 additions, -197 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/bucket.go` (+12 -28) ➕ `fakestorage/json_response.go` (+55 -0) 📝 `fakestorage/object.go` (+56 -66) 📝 `fakestorage/server.go` (+15 -15) 📝 `fakestorage/upload.go` (+66 -88) </details> ### 📄 Description Also improves error reporting. Closes #456. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:30:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#630
No description provided.