[PR #426] [MERGED] Disable gzipped responses #599

Closed
opened 2026-03-03 12:30:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/426
Author: @fsouza
Created: 2/15/2021
Status: Merged
Merged: 2/20/2021
Merged by: @fsouza

Base: mainHead: remove-gzip-from-response


📝 Commits (1)

  • 7be6807 Disable gzipped responses

📊 Changes

3 files changed (+0 additions, -6 deletions)

View changed files

📝 fakestorage/server.go (+0 -2)
📝 go.mod (+0 -1)
📝 go.sum (+0 -3)

📄 Description

The Java SDK sends gzipped requests, and some clients will send the
appropriate accept headers, but we don't need to send gzipped
responses. This makes the server simpler and easier to debug. Plus,
supporting the Java SDK doesn't require gzipped responses.

The idea here is to debug and potentially use this as the fix for #419.
This should have no effect on gzipped requests.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/426 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 2/15/2021 **Status:** ✅ Merged **Merged:** 2/20/2021 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `remove-gzip-from-response` --- ### 📝 Commits (1) - [`7be6807`](https://github.com/fsouza/fake-gcs-server/commit/7be68070d0973ec2080876dce6ecbe9b51cec9c8) Disable gzipped responses ### 📊 Changes **3 files changed** (+0 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/server.go` (+0 -2) 📝 `go.mod` (+0 -1) 📝 `go.sum` (+0 -3) </details> ### 📄 Description The Java SDK sends gzipped requests, and some clients will send the appropriate accept headers, but we don't _need_ to send gzipped responses. This makes the server simpler and easier to debug. Plus, supporting the Java SDK doesn't require gzipped responses. The idea here is to debug and potentially use this as the fix for #419. This should have no effect on gzipped _requests_. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:30:47 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#599
No description provided.