[PR #228] [MERGED] Support Windows #440

New issue

Closed

opened 2026-03-03 12:30:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:30:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/228
Author: @kennytm
Created: 4/29/2020
Status: ✅ Merged
Merged: 4/30/2020
Merged by: @fsouza

Base: master ← Head: windows

📝 Commits (2)

c0ab8bf Fix gosec G306 error
3a50647 Support Windows

📊 Changes

5 files changed (+27 additions, -5 deletions)

View changed files

📝 fakestorage/object_test.go (+3 -0)
📝 internal/backend/backend_test.go (+1 -1)
📝 internal/backend/fs.go (+2 -2)
➕ internal/backend/time_windows.go (+18 -0)
📝 main.go (+3 -2)

📄 Description

Implemented the function which extracts the creation time on Windows, so the program can be built.
- Since the file creation time granularity is only down to 100ns, the tests are relaxed a bit.
Use filepath.Rel and filepath.ToSlash to calculate the object key from local path, rather than string manipulation, so the backslashes can be properly handled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/228 **Author:** [@kennytm](https://github.com/kennytm) **Created:** 4/29/2020 **Status:** ✅ Merged **Merged:** 4/30/2020 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `windows` --- ### 📝 Commits (2) - [`c0ab8bf`](https://github.com/fsouza/fake-gcs-server/commit/c0ab8bf544622ceda3a11d2043693fe774e92c9b) Fix gosec G306 error - [`3a50647`](https://github.com/fsouza/fake-gcs-server/commit/3a50647b0b894cea94742b55c8618998ad2ca1a1) Support Windows ### 📊 Changes **5 files changed** (+27 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object_test.go` (+3 -0) 📝 `internal/backend/backend_test.go` (+1 -1) 📝 `internal/backend/fs.go` (+2 -2) ➕ `internal/backend/time_windows.go` (+18 -0) 📝 `main.go` (+3 -2) </details> ### 📄 Description * Implemented the function which extracts the creation time on Windows, so the program can be built. * Since the file creation time granularity is only down to 100ns, the tests are relaxed a bit. * Use `filepath.Rel` and `filepath.ToSlash` to calculate the object key from local path, rather than string manipulation, so the backslashes can be properly handled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>