[PR #176] [MERGED] Fix capitalisation in md5Hash metadata #405

New issue

Closed

opened 2026-03-03 12:29:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:29:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/176
Author: @gh2k
Created: 2/12/2020
Status: ✅ Merged
Merged: 2/12/2020
Merged by: @fsouza

Base: master ← Head: fix-md5hash-case

📝 Commits (1)

28c1b83 Fix capitalisation in md5Hash metadata

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 fakestorage/object.go (+1 -1)
📝 fakestorage/object_test.go (+1 -1)
📝 fakestorage/response.go (+1 -1)

📄 Description

The md5Hash member of metadata objects is currently being returned incorrectly as md5hash.

This breaks things like md5 hash validation in the nodejs client. For example, this line in Google's client checks for the md5Hash member:
github.com/googleapis/nodejs-storage@63deb51d17/src/file.ts (L1385)

See also the documentation at https://cloud.google.com/storage/docs/json_api/v1/objects

This patch renames the variable when serialising.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/176 **Author:** [@gh2k](https://github.com/gh2k) **Created:** 2/12/2020 **Status:** ✅ Merged **Merged:** 2/12/2020 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `fix-md5hash-case` --- ### 📝 Commits (1) - [`28c1b83`](https://github.com/fsouza/fake-gcs-server/commit/28c1b83c3c9765243313bb0a1ed6cfa04c41a524) Fix capitalisation in md5Hash metadata ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+1 -1) 📝 `fakestorage/object_test.go` (+1 -1) 📝 `fakestorage/response.go` (+1 -1) </details> ### 📄 Description The `md5Hash` member of metadata objects is currently being returned incorrectly as `md5hash`. This breaks things like md5 hash validation in the nodejs client. For example, this line in Google's client checks for the `md5Hash` member: https://github.com/googleapis/nodejs-storage/blob/63deb51d1727519ff926c1aabc6b0b5fb6f87d12/src/file.ts#L1385 See also the documentation at https://cloud.google.com/storage/docs/json_api/v1/objects This patch renames the variable when serialising. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>