[PR #125] [MERGED] Support predefined canned ACL when creating object #360

New issue

Closed

opened 2026-03-03 12:29:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:29:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/125
Author: @lelikg
Created: 11/11/2019
Status: ✅ Merged
Merged: 11/20/2019
Merged by: @fsouza

Base: master ← Head: set-canned-acl

📝 Commits (10+)

f4e498c Merge pull request #1 from wix-playground/support-private-acl-for-objects
d48d54e Merge pull request #2 from fsouza/master
4fc7776 Merge remote-tracking branch 'origin/master'
1c9b7ce support predefined "cannedACL"
452d53d linter fixes
62b90b8 add predefinedacl to other upload types
37fc9c6 add content encoding to objects
5ab43c0 remove comment
dcb0bb7 add contentEncoding
7815ce5 support content encoding

📊 Changes

6 files changed (+226 additions, -80 deletions)

View changed files

📝 fakestorage/object.go (+42 -21)
📝 fakestorage/object_test.go (+15 -10)
📝 fakestorage/response.go (+42 -27)
📝 fakestorage/upload.go (+49 -15)
📝 fakestorage/upload_test.go (+70 -0)
📝 internal/backend/object.go (+8 -7)

📄 Description

also support full ACL rule instead of just entity

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/125 **Author:** [@lelikg](https://github.com/lelikg) **Created:** 11/11/2019 **Status:** ✅ Merged **Merged:** 11/20/2019 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `set-canned-acl` --- ### 📝 Commits (10+) - [`f4e498c`](https://github.com/fsouza/fake-gcs-server/commit/f4e498c92147b6185f581a5018fdb0da2972fc08) Merge pull request #1 from wix-playground/support-private-acl-for-objects - [`d48d54e`](https://github.com/fsouza/fake-gcs-server/commit/d48d54ef720878bffcdb3986051e0acfcd659a15) Merge pull request #2 from fsouza/master - [`4fc7776`](https://github.com/fsouza/fake-gcs-server/commit/4fc7776e51c3a2ece26e1a2b930195591f9784db) Merge remote-tracking branch 'origin/master' - [`1c9b7ce`](https://github.com/fsouza/fake-gcs-server/commit/1c9b7cec14aaa9fbb92d826a9e433b482ee3688b) support predefined "cannedACL" - [`452d53d`](https://github.com/fsouza/fake-gcs-server/commit/452d53d1ca150c069dd0e7d7612737973d1c151d) linter fixes - [`62b90b8`](https://github.com/fsouza/fake-gcs-server/commit/62b90b869bd44ffb982e44aad3138d1c494957ef) add predefinedacl to other upload types - [`37fc9c6`](https://github.com/fsouza/fake-gcs-server/commit/37fc9c6c478881a6eb4be4a90558969111d7307c) add content encoding to objects - [`5ab43c0`](https://github.com/fsouza/fake-gcs-server/commit/5ab43c0d11e02cf5e6220e2ae03397c1b7ee6db9) remove comment - [`dcb0bb7`](https://github.com/fsouza/fake-gcs-server/commit/dcb0bb715ddd6bc45dd8cf707eb016533e1cf5d4) add contentEncoding - [`7815ce5`](https://github.com/fsouza/fake-gcs-server/commit/7815ce56e951c8ee4746716637acaf6dc07f81ef) support content encoding ### 📊 Changes **6 files changed** (+226 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+42 -21) 📝 `fakestorage/object_test.go` (+15 -10) 📝 `fakestorage/response.go` (+42 -27) 📝 `fakestorage/upload.go` (+49 -15) 📝 `fakestorage/upload_test.go` (+70 -0) 📝 `internal/backend/object.go` (+8 -7) </details> ### 📄 Description also support full ACL rule instead of just entity --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>