main: compile golangci-lint on the fly #346

New issue

Closed

opened 2026-03-03 12:29:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:29:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/109
Author: @fsouza
Created: 10/24/2019
Status: ✅ Merged
Merged: 10/24/2019
Merged by: @fsouza

Base: master ← Head: speed-up-lint

📝 Commits (2)

a6e874a github/workflows/main: compile golangci-lint on the fly
86acfb1 github/workflows/main: golangci-lint the hard way

📊 Changes

1 file changed (+13 additions, -7 deletions)

View changed files

📝 .github/workflows/main.yml (+13 -7)

📄 Description

golangci-lint can be quickly installed using go modules, and that should
be faster. Without this change, our deps are getting downloaded twice.
While golangci-lint does have more dependencies than fake-gcs-server,
I'm banking on the fact that we won't need to download golangci-lint's
Docker image and this should speed things up :D

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/109 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 10/24/2019 **Status:** ✅ Merged **Merged:** 10/24/2019 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `speed-up-lint` --- ### 📝 Commits (2) - [`a6e874a`](https://github.com/fsouza/fake-gcs-server/commit/a6e874a3cf2607f85c9aede7bdeb3aeb5d895a56) github/workflows/main: compile golangci-lint on the fly - [`86acfb1`](https://github.com/fsouza/fake-gcs-server/commit/86acfb14b1333294860dc68c9c5f42219c617c90) github/workflows/main: golangci-lint the hard way ### 📊 Changes **1 file changed** (+13 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/main.yml` (+13 -7) </details> ### 📄 Description golangci-lint can be quickly installed using go modules, and that should be faster. Without this change, our deps are getting downloaded twice. While golangci-lint does have more dependencies than fake-gcs-server, I'm banking on the fact that we won't need to download golangci-lint's Docker image and this should speed things up :D --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>