mirror of
https://github.com/fsouza/fake-gcs-server.git
synced 2026-04-26 06:05:54 +03:00
[GH-ISSUE #198] python gcs client use generation as 0 when it is None, which is not supported/implemented yet. #31
Labels
No labels
bug
compatibility-issue
docker
documentation
enhancement
help wanted
needs information
pull-request
question
stale
unfortunate
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/fake-gcs-server#31
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kc-panw on GitHub (Mar 20, 2020).
Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/198
GCS client forms the GET url with param
generation=0which is not implemented in the server.So, if it's not implemented, the quick fix may be replacing all
if generationStr != ""to
if generationStr != "" && generationStr != "0"so that it uses
Server.GetObject()otherwise, get/download object will fail. We can easily reproduce this by running example code.
Just wonder if
GetObjectWithGeneration()will be implemented soon or any other better fix?@fsouza commented on GitHub (Apr 20, 2020):
Hi @kc-panw, thanks for reporting and sorry for the delayed response. There aren't any plans for implementing
GetObjectWithGeneration()at the moment, unfortunately.Regarding generation being 0, I just pushed a fix.
@linjun9 commented on GitHub (May 6, 2020):
Hi @fsouza, I ran into the same issue again by running the python sample code. The problem is you only update the
getObjectfunction, but there arerewriteObjectanddownloadObjectas well.Is there a reason that you don't want to update those two functions? Thanks in advance.
@fsouza commented on GitHub (May 6, 2020):
It was an oversight. Will push a fix, thanks for pinging me!