[PR #40] [MERGED] Add optional custom public host #289

Closed
opened 2026-03-03 12:10:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/40
Author: @jwhitlock
Created: 6/12/2019
Status: Merged
Merged: 6/13/2019
Merged by: @fsouza

Base: masterHead: add-public-host


📝 Commits (1)

  • 1b8227c Add optional custom public host

📊 Changes

2 files changed (+119 additions, -11 deletions)

View changed files

📝 fakestorage/server.go (+30 -11)
📝 fakestorage/server_test.go (+89 -0)

📄 Description

Add the ability to specify a different public host than storage.googleapis.com. This would be used by https://github.com/teone/gc-fake-storage to serve files. This is set before buildMuxer() is called, and can be returned by PublicURL().


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/40 **Author:** [@jwhitlock](https://github.com/jwhitlock) **Created:** 6/12/2019 **Status:** ✅ Merged **Merged:** 6/13/2019 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `add-public-host` --- ### 📝 Commits (1) - [`1b8227c`](https://github.com/fsouza/fake-gcs-server/commit/1b8227c0ff241b3e5d222cf9ee4fdb8c4156adc7) Add optional custom public host ### 📊 Changes **2 files changed** (+119 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/server.go` (+30 -11) 📝 `fakestorage/server_test.go` (+89 -0) </details> ### 📄 Description Add the ability to specify a different public host than ``storage.googleapis.com``. This would be used by https://github.com/teone/gc-fake-storage to serve files. This is set before ``buildMuxer()`` is called, and can be returned by ``PublicURL()``. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:10:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#289
No description provided.