[PR #18] [MERGED] fakestorage: add support for MD5 checksum of object content #270

Closed
opened 2026-03-03 12:10:00 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/18
Author: @whiteley
Created: 3/14/2019
Status: Merged
Merged: 3/15/2019
Merged by: @fsouza

Base: masterHead: add-md5


📝 Commits (1)

  • e5cce07 fakestorage: add support for MD5 checksum of object content

📊 Changes

7 files changed (+64 additions, -13 deletions)

View changed files

📝 fakestorage/object.go (+5 -1)
📝 fakestorage/object_test.go (+17 -2)
📝 fakestorage/response.go (+9 -7)
📝 fakestorage/upload.go (+19 -2)
📝 fakestorage/upload_test.go (+8 -0)
📝 internal/backend/backend_test.go (+5 -1)
📝 internal/backend/object.go (+1 -0)

📄 Description

We'd like to use this library to test some GCS related code that relies on the MD5 object attributes. From my testing, I believe this to be correct and I greatly cribbed off the crc32c implementation. Happy to implement any improvements suggested though.

Thanks for the library!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/18 **Author:** [@whiteley](https://github.com/whiteley) **Created:** 3/14/2019 **Status:** ✅ Merged **Merged:** 3/15/2019 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `add-md5` --- ### 📝 Commits (1) - [`e5cce07`](https://github.com/fsouza/fake-gcs-server/commit/e5cce07a1cdeb8883c31ee6d9ea5758deced500a) fakestorage: add support for MD5 checksum of object content ### 📊 Changes **7 files changed** (+64 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+5 -1) 📝 `fakestorage/object_test.go` (+17 -2) 📝 `fakestorage/response.go` (+9 -7) 📝 `fakestorage/upload.go` (+19 -2) 📝 `fakestorage/upload_test.go` (+8 -0) 📝 `internal/backend/backend_test.go` (+5 -1) 📝 `internal/backend/object.go` (+1 -0) </details> ### 📄 Description We'd like to use this library to test some GCS related code that relies on the MD5 object attributes. From my testing, I believe this to be correct and I greatly cribbed off the crc32c implementation. Happy to implement any improvements suggested though. Thanks for the library! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:10:00 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#270
No description provided.