[GH-ISSUE #389] Avoid direct dependency on Google's deprecated SDK #2223

New issue

Closed

opened 2026-03-15 18:07:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 18:07:10 +03:00

Owner

Originally created by @fsouza on GitHub (Dec 22, 2020).
Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/389

Another thing we noticed while debugging #142: we're embedding a type from google.golang.org/api/storage/v1 in objectResponse. So, first, embedding a type from a third-party package in a struct that gets JSON-serialized is just bad, because we can't control the serialization via struct tags, but it's even worse that google.golang.org/api/storage/v1 is deprecated and we shouldn't be using it.

Originally created by @fsouza on GitHub (Dec 22, 2020). Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/389 Another thing we noticed while debugging #142: we're embedding a type from `google.golang.org/api/storage/v1` in [objectResponse](https://github.com/fsouza/fake-gcs-server/blob/3497ef906a2c5452c4e051244f6ae705abae269f/fakestorage/response.go#L68-L84). So, first, embedding a type from a third-party package in a struct that gets JSON-serialized is just bad, because we can't control the serialization via struct tags, but it's even worse that `google.golang.org/api/storage/v1` is deprecated and we shouldn't be using it.