[GH-ISSUE #239] Expected headers are not sent for ObjectHandle.NewReader() #2198

New issue

Closed

opened 2026-03-15 17:59:22 +03:00 by kerem · 3 comments

kerem commented

2026-03-15 17:59:22 +03:00

Owner

Originally created by @ericnorris on GitHub (May 8, 2020).
Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/239

The Reader you get from ObjectHandle.NewReader has an Attrs field of type ReaderObjectAttrs.

The storage library fills those values in based on headers sent in the response:

github.com/googleapis/google-cloud-go@bd00477b30/storage/reader.go (L255-L268)

As far as I can tell, fakestorage is not setting these headers, which means that you get something like the following when you try to use them:

reader attrs: {Size:56 StartOffset:0 ContentType: ContentEncoding: CacheControl: LastModified:0001-01-01 00:00:00 +0000 UTC Generation:-1 Metageneration:0}

This library has been great, but including these headers would make it so that I can safely use the Attrs attribute and be able to test. Thanks!

Originally created by @ericnorris on GitHub (May 8, 2020). Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/239 The [Reader](https://godoc.org/cloud.google.com/go/storage#Reader) you get from `ObjectHandle.NewReader` has an `Attrs` field of type [ReaderObjectAttrs](https://godoc.org/cloud.google.com/go/storage#ReaderObjectAttrs). The `storage` library fills those values in based on headers sent in the response: https://github.com/googleapis/google-cloud-go/blob/bd00477b309def1610fbf4cb259329deac795891/storage/reader.go#L255-L268 As far as I can tell, `fakestorage` is not setting these headers, which means that you get something like the following when you try to use them: ``` reader attrs: {Size:56 StartOffset:0 ContentType: ContentEncoding: CacheControl: LastModified:0001-01-01 00:00:00 +0000 UTC Generation:-1 Metageneration:0} ``` This library has been great, but including these headers would make it so that I can safely use the `Attrs` attribute _and_ be able to test. Thanks!

kerem closed this issue

2026-03-15 17:59:28 +03:00

kerem commented

2026-03-15 17:59:34 +03:00

Author

Owner

@fsouza commented on GitHub (May 11, 2020):

Hi @ericnorris, thanks for reporting. Can you check if #240 fixes the issue for you?

Thanks!

@fsouza commented on GitHub (May 11, 2020): Hi @ericnorris, thanks for reporting. Can you check if #240 fixes the issue for you? Thanks!

kerem commented

2026-03-15 17:59:39 +03:00

Author

Owner

@someone1 commented on GitHub (May 11, 2020):

I just conditionally added Content-Encoding - I don't think metadata generation is supported so I couldn't add that.

@someone1 commented on GitHub (May 11, 2020): I just conditionally added `Content-Encoding` - I don't think metadata generation is supported so I couldn't add that.

kerem commented

2026-03-15 17:59:44 +03:00

Author

Owner

@ericnorris commented on GitHub (May 12, 2020):

Hey @fsouza, I just had a chance to test locally and it does seem to fix the issue. Thanks, and thanks @someone1 for the quick fix!

@ericnorris commented on GitHub (May 12, 2020): Hey @fsouza, I just had a chance to test locally and it does seem to fix the issue. Thanks, and thanks @someone1 for the quick fix!