mirror of
https://github.com/fsouza/fake-gcs-server.git
synced 2026-04-26 14:15:49 +03:00
[GH-ISSUE #45] Add a dockerized server configuration #2160
Labels
No labels
bug
compatibility-issue
docker
documentation
enhancement
help wanted
needs information
pull-request
question
stale
unfortunate
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/fake-gcs-server#2160
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jwhitlock on GitHub (Jul 2, 2019).
Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/45
https://github.com/teone/gc-fake-storage provides a
Dockerfileand related scripts to allow this code to be run as a server, so that it can be used outside of tests of Go code. This Docker image is published at https://hub.docker.com/r/matteoscandolo/gc-fake-storage.It would be easier to improve and test this use case if the Docker configuration was part of this project instead. It could be easier to coordinate creating a new image when the library changes. Also, contributors could collaborate on language-specific clients, verified by integration tests.
There is no explicit license on https://github.com/teone/gc-fake-storage, which I believe means @teone has the copyright, which makes it incompatible with this project's BSD 2 license, copyright Francisco Souza. I believe the clearest way to merge the code is if @teone makes the initial PR, which makes it clear he's contributing under the license for this this project. After the initial merge of files, I'd be happy to make additional changes.
This was first discussed on closed PR https://github.com/fsouza/fake-gcs-server/pull/39#issuecomment-501852822
@fsouza commented on GitHub (Jul 12, 2019):
@jwhitlock I'm planning to give a shot at this next week. If we don't hear back from @teone, I can create a different main package under
cmd/fake-gcs(orcmd/gcs-emulator, dunno).@teone commented on GitHub (Jul 12, 2019):
Hi @fsouza and @jwhitlock https://github.com/jwhitlock,
I'll be more than happy to make a pull request!
I should be able to do it aome time next week
On Thu, Jul 11, 2019, 6:16 PM francisco notifications@github.com wrote:
@fsouza commented on GitHub (Jul 12, 2019):
Nice! Will wait then :D
@fsouza commented on GitHub (Jul 16, 2019):
@jwhitlock @teone please take a look at #46.