[PR #2128] [MERGED] fix: return updated bucket JSON from updateBucket endpoint #2122

Closed
opened 2026-03-03 13:29:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/2128
Author: @fsouza
Created: 1/31/2026
Status: Merged
Merged: 1/31/2026
Merged by: @fsouza

Base: mainHead: fix/update-bucket-return-json


📝 Commits (1)

  • 1934a97 fix: return updated bucket JSON from updateBucket endpoint

📊 Changes

3 files changed (+43 additions, -16 deletions)

View changed files

📝 fakestorage/bucket.go (+17 -7)
📝 fakestorage/bucket_test.go (+23 -8)
📝 internal/backend/memory.go (+3 -1)

📄 Description

The updateBucket endpoint was returning an empty response instead of the updated bucket JSON. This broke Java clients which expect the name field in the response per GCS API docs.

Fixes #2087


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/2128 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 1/31/2026 **Status:** ✅ Merged **Merged:** 1/31/2026 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `fix/update-bucket-return-json` --- ### 📝 Commits (1) - [`1934a97`](https://github.com/fsouza/fake-gcs-server/commit/1934a97d1dc0f0643e83509dd43e0ff9e3f54c7f) fix: return updated bucket JSON from updateBucket endpoint ### 📊 Changes **3 files changed** (+43 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/bucket.go` (+17 -7) 📝 `fakestorage/bucket_test.go` (+23 -8) 📝 `internal/backend/memory.go` (+3 -1) </details> ### 📄 Description The updateBucket endpoint was returning an empty response instead of the updated bucket JSON. This broke Java clients which expect the name field in the response per GCS API docs. Fixes #2087 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 13:29:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#2122
No description provided.