[PR #1999] [MERGED] feat: build the urls in the response based on request #2007

Closed
opened 2026-03-03 12:37:12 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1999
Author: @jochen42
Created: 8/14/2025
Status: Merged
Merged: 1/31/2026
Merged by: @fsouza

Base: mainHead: 1998-support-dynamic-scheme-host-port


📝 Commits (2)

  • 3d94b06 feat: build the urls in the response based on request
  • ee235f4 internal/urlhelper: rename package

📊 Changes

4 files changed (+122 additions, -11 deletions)

View changed files

📝 fakestorage/object.go (+5 -4)
📝 fakestorage/upload.go (+8 -7)
internal/urlhelper/url.go (+21 -0)
internal/urlhelper/url_test.go (+88 -0)

📄 Description

adds feature #1998


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1999 **Author:** [@jochen42](https://github.com/jochen42) **Created:** 8/14/2025 **Status:** ✅ Merged **Merged:** 1/31/2026 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `1998-support-dynamic-scheme-host-port` --- ### 📝 Commits (2) - [`3d94b06`](https://github.com/fsouza/fake-gcs-server/commit/3d94b06e15b4450621d2bc642cdc59c903f43908) feat: build the urls in the response based on request - [`ee235f4`](https://github.com/fsouza/fake-gcs-server/commit/ee235f4bb23df813ddfc238bba81735f3db704c1) internal/urlhelper: rename package ### 📊 Changes **4 files changed** (+122 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+5 -4) 📝 `fakestorage/upload.go` (+8 -7) ➕ `internal/urlhelper/url.go` (+21 -0) ➕ `internal/urlhelper/url_test.go` (+88 -0) </details> ### 📄 Description adds feature #1998 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:37:12 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#2007
No description provided.