[PR #1979] [MERGED] Fix direct dependency on grpc/stats/opentelemetry to avoid conflicts #1989

Closed
opened 2026-03-03 12:37:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1979
Author: @DenKoren
Created: 6/13/2025
Status: Merged
Merged: 6/16/2025
Merged by: @fsouza

Base: mainHead: main


📝 Commits (1)

  • d970a76 Fix direct dependency on grpc/stats/opentelemetry to avoid conflicts

📊 Changes

2 files changed (+33 additions, -36 deletions)

View changed files

📝 go.mod (+11 -12)
📝 go.sum (+22 -24)

📄 Description

The dependency on google.golang.org/grpc/stats/opentelemetry instead of google.golang.org/grpc package makes it impossible to incorporate fake-gcs-server/fakestorage into go tests that use modern version of gcloud SDK for go.
Even module module replacements for google.golang.org/grpc/stats/opentelemetry do not solve the problem.
The only way is to replace fake-gcs-server/fakestorage with custom fork.

This version update followed by go mod tidy solves the problem.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1979 **Author:** [@DenKoren](https://github.com/DenKoren) **Created:** 6/13/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`d970a76`](https://github.com/fsouza/fake-gcs-server/commit/d970a76437fcea1039896fd97ab0806df8f3ab7e) Fix direct dependency on grpc/stats/opentelemetry to avoid conflicts ### 📊 Changes **2 files changed** (+33 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+11 -12) 📝 `go.sum` (+22 -24) </details> ### 📄 Description The dependency on `google.golang.org/grpc/stats/opentelemetry` instead of `google.golang.org/grpc` package makes it impossible to incorporate `fake-gcs-server/fakestorage` into go tests that use modern version of gcloud SDK for go. Even module module replacements for `google.golang.org/grpc/stats/opentelemetry` do not solve the problem. The only way is to replace `fake-gcs-server/fakestorage` with custom fork. This version update followed by `go mod tidy` solves the problem. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:37:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#1989
No description provided.