[PR #1902] [MERGED] Use default temporary directory in tests #1923

Closed
opened 2026-03-03 12:36:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1902
Author: @commiterate
Created: 2/14/2025
Status: Merged
Merged: 2/16/2025
Merged by: @fsouza

Base: mainHead: nixpkgs_prep


📝 Commits (1)

  • 18d56b7 Use default temporary directory in tests

📊 Changes

3 files changed (+3 additions, -29 deletions)

View changed files

📝 fakestorage/bucket_test.go (+1 -10)
📝 internal/backend/backend_test.go (+1 -9)
📝 internal/grpc/server_test.go (+1 -10)

📄 Description

Removing the Linux temporary directory hardcode in unit tests as it breaks sandboxed builds.


For packaging fake-gcs-server in Nixpkgs (will need a new release with the fixes).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1902 **Author:** [@commiterate](https://github.com/commiterate) **Created:** 2/14/2025 **Status:** ✅ Merged **Merged:** 2/16/2025 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `nixpkgs_prep` --- ### 📝 Commits (1) - [`18d56b7`](https://github.com/fsouza/fake-gcs-server/commit/18d56b7c82b3d0fe36b8420a0d521e45d1e6d264) Use default temporary directory in tests ### 📊 Changes **3 files changed** (+3 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/bucket_test.go` (+1 -10) 📝 `internal/backend/backend_test.go` (+1 -9) 📝 `internal/grpc/server_test.go` (+1 -10) </details> ### 📄 Description Removing the Linux temporary directory hardcode in unit tests as it breaks sandboxed builds. --- For packaging `fake-gcs-server` in Nixpkgs (will need a new release with the fixes). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:36:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#1923
No description provided.