[PR #1827] [MERGED] fix: avoid IncompleteRead on completed partial reads #1855

Closed
opened 2026-03-03 12:36:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1827
Author: @fcanovai
Created: 11/26/2024
Status: Merged
Merged: 1/3/2025
Merged by: @fsouza

Base: mainHead: incompletereadfix


📝 Commits (2)

  • ce3b0ea fix: avoid IncompleteRead on completed partial reads
  • aa548e2 fakestorage: add a test for invalid range

📊 Changes

2 files changed (+29 additions, -1 deletions)

View changed files

📝 fakestorage/object.go (+1 -1)
📝 fakestorage/object_test.go (+28 -0)

📄 Description

Fix a bug in which the server would return a 416 reply with an empty body declaring a Content-Length of 1.

Closes #1761


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1827 **Author:** [@fcanovai](https://github.com/fcanovai) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 1/3/2025 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `incompletereadfix` --- ### 📝 Commits (2) - [`ce3b0ea`](https://github.com/fsouza/fake-gcs-server/commit/ce3b0eae0d759756f789c7580ec7e6f699b02540) fix: avoid IncompleteRead on completed partial reads - [`aa548e2`](https://github.com/fsouza/fake-gcs-server/commit/aa548e2e3508ae9d080a081abfb26a1fc5a04fe0) fakestorage: add a test for invalid range ### 📊 Changes **2 files changed** (+29 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+1 -1) 📝 `fakestorage/object_test.go` (+28 -0) </details> ### 📄 Description Fix a bug in which the server would return a 416 reply with an empty body declaring a Content-Length of 1. Closes #1761 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:36:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#1855
No description provided.