[PR #1801] [MERGED] Disallow uppercase in bucket names #1830

New issue

Closed

opened 2026-03-03 12:36:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:36:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1801
Author: @bryfox
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @fsouza

Base: main ← Head: fix/bucket-uppercase

📝 Commits (1)

b5a2937 Disallow uppercase in bucket names

📊 Changes

2 files changed (+3 additions, -1 deletions)

View changed files

📝 fakestorage/bucket.go (+2 -1)
📝 fakestorage/bucket_test.go (+1 -0)

📄 Description

This updates the pattern for valid bucket names to remove support for uppercase characters.

Per https://cloud.google.com/storage/docs/buckets#naming:

Bucket names can only contain lowercase letters, numeric characters, dashes (-), underscores (_), and dots (.).

I imagine this is a potentially breaking change depending on peoples' setups/fixture data, but this would have caught a bug for one of our projects when changing an internal naming pattern.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1801 **Author:** [@bryfox](https://github.com/bryfox) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `fix/bucket-uppercase` --- ### 📝 Commits (1) - [`b5a2937`](https://github.com/fsouza/fake-gcs-server/commit/b5a293758db73b36d9ed4bb455ead9f4fd32b443) Disallow uppercase in bucket names ### 📊 Changes **2 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/bucket.go` (+2 -1) 📝 `fakestorage/bucket_test.go` (+1 -0) </details> ### 📄 Description This updates the pattern for valid bucket names to remove support for uppercase characters. Per https://cloud.google.com/storage/docs/buckets#naming: > Bucket names can only contain lowercase letters, numeric characters, dashes (-), underscores (_), and dots (.). I imagine this is a potentially breaking change depending on peoples' setups/fixture data, but this would have caught a bug for one of our projects when changing an internal naming pattern. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>