[PR #1779] [MERGED] internal/grpc: use the generated proto provided by Google #1810

New issue

Closed

opened 2026-03-03 12:36:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:36:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1779
Author: @fsouza
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/15/2024
Merged by: @fsouza

Base: main ← Head: update-proto

📝 Commits (2)

9b0b89f internal/grpc: use the generated proto provided by Google
f681c8c internal/grpc: fix naming convention for variables

📊 Changes

6 files changed (+141 additions, -14091 deletions)

View changed files

➖ genproto/googleapis/storage/v1/storage.pb.go (+0 -9385)
➖ genproto/googleapis/storage/v1/storage_resources.pb.go (+0 -4610)
📝 go.mod (+3 -3)
➕ internal/grpc/fake_grpc_servers_test.go (+52 -0)
📝 internal/grpc/server.go (+47 -53)
📝 internal/grpc/server_test.go (+39 -40)

📄 Description

This is better than trying to maintain our own generated stuff.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1779 **Author:** [@fsouza](https://github.com/fsouza) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/15/2024 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `update-proto` --- ### 📝 Commits (2) - [`9b0b89f`](https://github.com/fsouza/fake-gcs-server/commit/9b0b89f70694c0176926bf0095d96e84c5db8e66) internal/grpc: use the generated proto provided by Google - [`f681c8c`](https://github.com/fsouza/fake-gcs-server/commit/f681c8c58c79a61e6dd0194b6daea962ceb06648) internal/grpc: fix naming convention for variables ### 📊 Changes **6 files changed** (+141 additions, -14091 deletions) <details> <summary>View changed files</summary> ➖ `genproto/googleapis/storage/v1/storage.pb.go` (+0 -9385) ➖ `genproto/googleapis/storage/v1/storage_resources.pb.go` (+0 -4610) 📝 `go.mod` (+3 -3) ➕ `internal/grpc/fake_grpc_servers_test.go` (+52 -0) 📝 `internal/grpc/server.go` (+47 -53) 📝 `internal/grpc/server_test.go` (+39 -40) </details> ### 📄 Description This is better than trying to maintain our own generated stuff. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>