[PR #1630] [MERGED] Support content-disposition #1675

New issue

Closed

opened 2026-03-03 12:35:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:35:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/1630
Author: @yuk1ty
Created: 6/6/2024
Status: ✅ Merged
Merged: 9/22/2024
Merged by: @fsouza

Base: main ← Head: feature/add-content-disposition

📝 Commits (1)

fab754d Support content-disposition

📊 Changes

6 files changed (+187 additions, -155 deletions)

View changed files

📝 fakestorage/object.go (+128 -108)
📝 fakestorage/object_test.go (+17 -12)
📝 fakestorage/response.go (+2 -0)
📝 fakestorage/upload.go (+14 -12)
📝 internal/backend/object.go (+16 -15)
📝 internal/grpc/server.go (+10 -8)

📄 Description

Hi, this is for the first time to contribute to this project. Thank you for making such a great tool 🙌🏻

Recently I attempted to use this emulator in my work and I found that setting Content-Disposition didn't work well. I tried to support the Content-Disposition feature.

To be honest I'm a beginner of Google Cloud Storage itself so I might have missed lots of things more than likely. I would appreciate any feedback!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/1630 **Author:** [@yuk1ty](https://github.com/yuk1ty) **Created:** 6/6/2024 **Status:** ✅ Merged **Merged:** 9/22/2024 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `feature/add-content-disposition` --- ### 📝 Commits (1) - [`fab754d`](https://github.com/fsouza/fake-gcs-server/commit/fab754d247d29cff3f46b693256deb799f8bb0ca) Support content-disposition ### 📊 Changes **6 files changed** (+187 additions, -155 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+128 -108) 📝 `fakestorage/object_test.go` (+17 -12) 📝 `fakestorage/response.go` (+2 -0) 📝 `fakestorage/upload.go` (+14 -12) 📝 `internal/backend/object.go` (+16 -15) 📝 `internal/grpc/server.go` (+10 -8) </details> ### 📄 Description Hi, this is for the first time to contribute to this project. Thank you for making such a great tool 🙌🏻 Recently I attempted to use this emulator in my work and I found that setting `Content-Disposition` didn't work well. I tried to support the `Content-Disposition` feature. To be honest I'm a beginner of Google Cloud Storage itself so I might have missed lots of things more than likely. I would appreciate any feedback! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>